Uh oh!
There was an error while loading. Please reload this page.
fix(runtime): preserve recovered message order - #1501
Merged
Conversation
Astro-Han
approved these changes
Jul 26, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the recovered-message ordering path and persistence boundaries. flushPendingSteps() fixes the text-only recovery order in the replay materializer without changing the storage contract or breaking same-step text/tool pairing. The regression test and full runtime suite pass. Approved.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user A -> assistant A -> user BContext
Follow-up to #1462. Post-merge review found that treating every recovered assistant
storedMessageIdas a step id could park a text-only assistant message until the end of replay, moving it after a later user message.The fix stays at the replay materializer boundary: pending assistant steps are emitted before crossing to the next conversation message.
Refs #1269.
Verification
npm test: all workspace tests passednpm run format:check: 1,088 files passednpm run lint: 2,131 files passednpm run typecheck: all workspaces passedgit diff --checkpassed