Uh oh!
There was an error while loading. Please reload this page.
PR-SETTINGS-NAV-REGROUP-0: 5 nav groups → 3 + Beta badge primitive - #152
Merged
Conversation
WAWQAQ msg `a9ef0d5d`: maka has 5 settings nav groups (基础, AI, 集成, 数据, 其他) with `数据` carrying only a single item — visibly noisy. Reference uses 3 groups with one big "kitchen sink" group instead. Changes: - `NAV_GROUP_ORDER` 5 → 3: - 基础 → 通用 - AI + 集成 → AI 与集成 (merged) - 数据 + 其他 → 系统 (merged) - `deriveNavGroupSummary` updated: AI 与集成 falls through AI summary first, then integrations summary if no AI signals to surface. - `SettingsNavItem.badge?: 'Beta'` field added; renders a small accent-tinted chip in the 3rd grid column of `.settingsNavItem`. Initial use: 联网搜索 → Beta (the Tavily provider integration is the only beta-stage feature live today). - `.settingsNavBadge` primitive: 18px tall, 6px radius, 12% accent bg, accent text, 10px / 600 / 0.04em tracking. - `.settingsNavItem` grid `24 1fr` → `24 1fr auto` for badge column. Contract test (settings-roadmap-cleanup-contract) loosened the class-name ban on `settingsNavBadge` since the primitive is now legitimately reused as a Beta chip. The copy-level "即将推出 / roadmap / providerComingSoon" bans still hold. 1466 / 1466 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAWQAQ a9ef0d5d. Maka had 5 sidebar groups (one with a single item); reference uses 3 groups with one big aggregator. Merged 基础→通用, AI+集成→「AI 与集成」, 数据+其他→系统. Added
badge?: 'Beta'field on SettingsNavItem rendered as small accent-tinted chip in a new 3rd grid column. 联网搜索 marked Beta. nav-group-summary.ts updated to fall through AI then integrations summaries. 1466 tests pass.