Uh oh!
There was an error while loading. Please reload this page.
PR-SETTINGS-MOTION-TYPO-TOKENS-0: tactile + tabular + balance + accent bar + hint 14 + motion token (round 15/15) - #158
Merged
Conversation
…t bar + hint 14 + motion token (round 15/15) Final round of the 15-loop. Bundles 6 high-convergence findings from the parallel deep-read of 5 UI-design skill collections (digest in `notes/ui-skills-deep-read-2026-06-23.md`): 1. **Shared motion tokens** — `--motion-fast: 160ms` + `--motion-ease-out: cubic-bezier(0.16, 1, 0.3, 1)` scoped to the settings surface. Eliminates scattered 150ms values. 2. **`:active` tactile feedback** — `scale(0.985)` + 100ms ease-out on settings rows, nav items, back button. Reduced-motion @media strips the transform. 12-principles + Taste-Skill + UIDB all converge here. 3. **Sidebar active accent bar** — `box-shadow: inset 3px 0 0 var(--accent)` on `data-active=true` nav items. Carries brand into the most-used surface without recoloring the fill. 4. **`tabular-nums` on value cells** — `.settingsRow > span` `font-variant-numeric: tabular-nums` so version strings / model IDs / counts align cleanly. 5. **`text-balance` / `text-pretty`** on page header — h2 gets balance (no awkward 2-word breaks), subtitle gets pretty (no orphan last word). 6. **Hint floor 13 → 14px**, line-height 1.45 → 1.5 — crosses the ≥14px legibility floor that baseline-ui + UIDB + Impeccable `/typeset` independently require. Loop summary: started with a "30-round 5-min polish loop" ask, ended with 15 ships covering shell layout, IA consolidation, page body, row chrome, sidebar regrouping, page subtitles, a11y rings, focus states, motion tokens, typography, and a 3-source UI-design RE. 1466 / 1466 tests pass.
jackwener added a commit
that referenced
this pull request
Aug 7, 2026
* fix(settings): let the models page set the default connection Closes#158. Changing the default connection was possible only from the command palette. The models page displayed a 默认 Badge on whichever connection held it and offered no way to change it — so a user who went looking where the answer is shown found a read-only label. One of them said so: "这默认模型连接改不了吗, 在模型里找半天." They were looking in exactly the right place. The badge slot in the connection detail header now carries both halves of the same fact: the default connection shows the Badge, and any other connection shows a 设为默认 button in its place. Whichever a connection is, that slot tells you — and is how you change it. `clickAction` rather than onClick: this opens no confirmation, so there is no state-driven UI to await inside the transition, and the pending affordance comes with it. On failure the toast reports and the state does not move, which leaves the button where it was to retry. The command palette entry stays. It was never wrong, only invisible. * fix(settings): make the set-default control read as a control Review caught that ghost was the wrong variant here. A ghost button alone beside a title is bare text, which reads as a subtitle rather than something pressable — recreating the exact problem this change exists to solve, on the one surface where a user has already demonstrated that not-obvious means not-found. secondary sm matches 测试连接 directly below it, which is this page's dialect for a quiet but unmistakable control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final round of the 15-loop. Six high-convergence findings bundled from 3 parallel deep-reads of 5 UI-design skill collections (notes/ui-skills-deep-read-2026-06-23.md). Motion tokens, :active tactile feedback, sidebar inset accent bar, tabular-nums on value cells, h2/subtitle text-balance/pretty, hint 13→14. 1466 tests pass.