Uh oh!
There was an error while loading. Please reload this page.
PR-SETTINGS-PERMISSION-POLISH-0: roomier permission cards + status-tinted icon - #160
Merged
Conversation
…nted icon WAWQAQ msg `6a04b077` showed a side-by-side: reference's permission cards have visibly more breathing room than maka's. Bumped: - `.settingsOsPermissionList` gap 6 → 12 between cards - `.settingsOsPermissionRow` padding 12/14 → 16/18, gap 12 → 14, radius 8 → 10 - `.settingsOsPermissionIcon` 32 → 36 + radius 8 → 9 - `.settingsOsPermissionHeading strong` 0.875rem (14) → 15 px - `.settingsOsPermissionPurpose` 0.78rem (12.5) → 13 px / lh 1.5 → 1.55 - `.settingsOsPermissionImpact` 0.74rem (11.8) → 12 px / tone 65 → 60 - Status-tinted icon plate: granted → 10% success bg / success color; denied → 10% destructive bg / destructive color (matches reference's pastel chip-icon look) The bordered-card-per-row pattern stays — that's correct for permission items (icon + name + status chip + button + impact subline) per WAWQAQ's content-density rule. 1467 / 1467 tests pass.
This was referenced Aug 7, 2026
jackwener added a commit
that referenced
this pull request
Aug 7, 2026
Completes the two actions #160 deferred, so the Projects page manages a project rather than only choosing a default. Reveal takes a project id, never a path. Main asks the catalog where that project lives and the existing `project` open-path guard re-checks the resolved directory, so the renderer cannot name an arbitrary folder for the shell to open. It is offered only while the catalog still vouches for the folder — a menu entry that could only fail is worse than one that is absent. Rename reuses `SettingsExpandableRow` rather than hand-rolling a second editor; it already owns the focus move into the field and back to the row, and the reasoning about why it carries no aria-expanded. It gained an `end` prop so a row that already owns its end slot — a default Badge, 设为默认, and the … menu — keeps that cluster instead of growing a second competing button. Rename is reached from the menu. Each row's … menu is now named after its project. Four buttons all called 更多操作 are one button to assistive tech; they were equally ambiguous to a test, which addressed a row by index and renamed the wrong project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAWQAQ 6a04b077 side-by-side: reference permission cards breathe more than maka's. Bumped gap 6→12, padding 12/14→16/18, icon 32→36, label 14→15, purpose 12.5→13. Added status-tinted icon plate (10% success bg on granted, 10% destructive on denied) matching reference's pastel chip look. Per-row card stays — correct for permission row content density.