Uh oh!
There was an error while loading. Please reload this page.
fix(desktop): drop the deleted PermissionEngine from a main test - #1608
Merged
Conversation
#1581 replaced tool permissions with session sandbox boundaries and removed `PermissionEngine` from `@maka/runtime`, but left this test importing it and passing a `permissionEngine` dependency that the session-stream deps type no longer has. `main` has been red since: `tsc -p tsconfig.main.json` fails with TS2305, which takes `build:main` down and with it the typecheck, test, and e2e jobs on every branch. Nothing in production takes a `permissionEngine` any more, and the test's subject is usage readiness, so the import and the dependency go. No behavioural change and no replacement needed.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis red, and has been since #1581. That PR replaced tool permissions with session sandbox boundaries and removedPermissionEnginefrom@maka/runtime, butapps/desktop/src/main/__tests__/session-stream-usage-readiness.test.tsstill imports it and still passes apermissionEnginedependency that the session-stream deps type no longer declares.tsc -p tsconfig.main.jsonfails withTS2305: Module '"@maka/runtime"' has no exported member 'PermissionEngine', which takesbuild:maindown — and with it thetypecheck,test, ande2ejobs on every branch, since all three build first.PermissionEngineno longer exists anywhere in the repo, and nothing in production code accepts apermissionEngine, so the import and the dependency are simply removed. The test's subject is usage readiness; it needs no replacement.Refs #1581
Verification
npm run build(all workspaces, from this branch) — clean; it fails onorigin/mainatbuild:mainnode --test dist/main/__tests__/session-stream-usage-readiness.test.js— 1 pass, 0 failmainrun for comparison: https://github.com/maka-agent/maka-agent/actions — the tip commit (test(graph): cover large supervisor outputs #1602) isfailurewith this same TS2305