Skip to content

fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
Aug 3, 2026
+351 −71
Merged

fix(headless): require validated verifier grades #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea1c392
fix(headless): reject sparse verifier attempts
me2seeks Jul 30, 2026
f14cbba
fix(headless): require validated verifier grades
me2seeks Jul 30, 2026
0835442
fix(headless): reproject rejected stored verifier grades
me2seeks Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
274 changes: 264 additions & 10 deletions packages/headless/src/__tests__/fixed-prompt-controller.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
});
});

test('keeps rejected runner verifier output ungraded', async () => {
await withDir(async (dir) => {
const systemPromptPath = join(dir, 'system_prompt.md');
await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
const sparseAttempts = new Array(2) as NonNullable<
TaskRunOutput['harbor']['verifier']
>['attempts'];
sparseAttempts[1] = {
attempt: 2,
classification: 'failed',
durationMs: 20,
reward: 0,
};

for (const { label, reward, verifier } of [
{ label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
{
label: 'non-array-attempts',
reward: 0,
verifier: { outcome: 'failed', attempts: 'not-an-array' },
},
{
label: 'sparse-attempts',
reward: 0,
verifier: { outcome: 'failed', attempts: sparseAttempts },
},
{
label: 'reward-disagreement',
reward: 1,
verifier: {
outcome: 'failed',
attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
},
},
] as const) {
const result = await runFixedPromptController({
runId: `run-${label}`,
roundId: 'round-1',
config,
systemPromptPath,
resultsJsonlPath: join(dir, `results-${label}.jsonl`),
tasks: [{ id: 'task-a', path: '/bench/task-a' }],
taskRunner: async () =>
harborOutput({
taskId: 'task-a',
reward,
status: 'failed',
errorClass: 'max_tokens',
verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
}),
});

assert.equal(result.events[0]?.type, 'task_completed');
assert.equal(result.events[0]?.passed, false);
assert.equal(result.events[0]?.scored, false);
assert.equal(result.events[0]?.eligible, false);
assert.equal(result.events[0]?.errorClass, 'max_tokens');
}
});
});

test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
await withDir(async (dir) => {
const systemPromptPath = join(dir, 'system_prompt.md');
await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
attempts[1] = {
attempt: 2,
classification: 'failed',
durationMs: 20,
reward: 0,
};

const result = await runFixedPromptController({
runId: 'run-1',
roundId: 'round-1',
config,
systemPromptPath,
resultsJsonlPath: join(dir, 'results.jsonl'),
tasks: [{ id: 'task-a', path: '/bench/task-a' }],
taskRunner: async () =>
harborOutput({
taskId: 'task-a',
reward: 0,
status: 'failed',
errorClass: 'network',
verifier: { outcome: 'failed', attempts },
}),
});

assert.equal(result.events[0]?.type, 'task_infra_failed');
assert.equal(result.events[0]?.scored, false);
assert.equal(result.events[0]?.eligible, false);
assert.equal(result.events[0]?.errorClass, 'network');
});
});

test('projects a stored structured verifier failure without resampling Harbor', async () => {
await withDir(async (dir) => {
const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
passed: false,
scored: false,
eligible: false,
errorClass: 'runtime_error',
errorClass: 'infra_failed',
harbor: {
reward: 0,
verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
});
});

test('keeps malformed stored verifier attempts on the ungraded path', async () => {
test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
await withDir(async (dir) => {
const systemPromptPath = join(dir, 'system_prompt.md');
await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
const sparseAttempts = new Array(2);
sparseAttempts[1] = {
attempt: 2,
classification: 'failed',
durationMs: 20,
reward: 0,
};

for (const [label, verifier] of [
['missing', { outcome: 'failed' }],
['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
for (const [label, reward, verifier, errorClass] of [
['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
[
'reward-disagreement',
1,
{
outcome: 'failed',
attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
},
'max_tokens',
],
['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
] as const) {
const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
...stored,
status: 'failed',
passed: false,
scored: false,
eligible: false,
errorClass: 'infra_failed',
harbor: { reward: 0, verifier },
scored: true,
eligible: true,
errorClass,
harbor: { reward, verifier },
})}\n`,
'utf8',
);
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

assert.equal(runnerCalls, 0);
assert.equal(result.events[0]?.type, 'task_completed');
assert.equal(result.events[0]?.passed, false);
assert.equal(result.events[0]?.scored, false);
assert.equal(result.events[0]?.eligible, false);
assert.equal(result.events[0]?.errorClass, 'infra_failed');
assert.equal(result.events[0]?.errorClass, errorClass);
}
});
});

test('removes a stale pass from rejected legacy verifier output', async () => {
await withDir(async (dir) => {
const resultsJsonlPath = join(dir, 'results.jsonl');
const stored = taskCompletedEvent({ taskId: 'task-a' });
assert.equal(stored.type, 'task_completed');
if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
const { errorClass: _storedErrorClass, ...legacy } = stored;
await writeFile(
resultsJsonlPath,
`${JSON.stringify({
...legacy,
status: 'failed',
passed: true,
scored: true,
eligible: true,
harbor: {
reward: 1,
verifier: {
outcome: 'failed',
attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
},
},
})}\n`,
'utf8',
);

const [projected] = await readFixedPromptWal(resultsJsonlPath);

assert.equal(projected?.type, 'task_completed');
assert.equal(projected?.passed, false);
assert.equal(projected?.scored, false);
assert.equal(projected?.eligible, false);
assert.equal(projected?.errorClass, 'verification_failed');
});
});

test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
await withDir(async (dir) => {
const resultsJsonlPath = join(dir, 'results.jsonl');
const base = taskCompletedEvent({ taskId: 'task-a' });
assert.equal(base.type, 'task_completed');
if (base.type !== 'task_completed') throw new Error('expected completed fixture');
const malformedVerifier = { outcome: 'failed' };
await writeFile(
resultsJsonlPath,
[
{
...base,
id: 'tool-step-cap',
taskId: 'tool-step-cap',
status: 'failed',
passed: false,
scored: true,
eligible: true,
errorClass: 'tool_step_cap_reached',
harbor: { reward: 0, verifier: malformedVerifier },
},
{
...base,
id: 'deadline',
taskId: 'deadline',
status: 'failed',
passed: false,
scored: true,
eligible: true,
errorClass: 'budget_exhausted',
deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
harbor: { reward: 0, verifier: malformedVerifier },
},
{
...base,
id: 'completed',
taskId: 'completed',
passed: false,
scored: true,
eligible: true,
errorClass: 'verification_failed',
harbor: { reward: 0, verifier: malformedVerifier },
},
{
...base,
id: 'no-verifier',
taskId: 'no-verifier',
status: 'failed',
passed: false,
scored: true,
eligible: true,
errorClass: 'max_tokens',
harbor: { reward: 0 },
},
]
.map((event) => JSON.stringify(event))
.join('\n') + '\n',
'utf8',
);

const projected = await readFixedPromptWal(resultsJsonlPath);
assert.deepEqual(
projected.map((event) => {
assert.equal(event.type, 'task_completed');
if (event.type !== 'task_completed') throw new Error('expected completed event');
return {
taskId: event.taskId,
scored: event.scored,
eligible: event.eligible,
errorClass: event.errorClass,
};
}),
[
{
taskId: 'tool-step-cap',
scored: false,
eligible: true,
errorClass: 'tool_step_cap_reached',
},
{
taskId: 'deadline',
scored: true,
eligible: true,
errorClass: 'budget_exhausted',
},
{
taskId: 'completed',
scored: true,
eligible: true,
errorClass: 'verification_failed',
},
{
taskId: 'no-verifier',
scored: true,
eligible: true,
errorClass: 'max_tokens',
},
],
);
});
});

test('projects a stored structured verifier pass without resampling Harbor', async () => {
await withDir(async (dir) => {
const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(headless): require validated verifier grades by me2seeks · Pull Request #1644 · apache/maka · GitHub
Skip to content
fix(headless): require validated verifier grades#1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 3 commits into

from

Aug 3, 2026

+351

−71

 Merged


fix(headless): require validated verifier grades
#1644
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
ea1c392

fix(headless): reject sparse verifier attempts


me2seeks Jul 30, 2026
f14cbba

fix(headless): require validated verifier grades


me2seeks Jul 30, 2026
0835442

fix(headless): reproject rejected stored verifier grades


me2seeks Aug 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


274 changes: 264 additions & 10 deletions
packages/headless/src/__tests__/fixed-prompt-controller.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3184,6 +3184,103 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps rejected runner verifier output ungraded', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2) as NonNullable<
 TaskRunOutput['harbor']['verifier']
 >['attempts'];
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const { label, reward, verifier } of [
 { label: 'missing-attempts', reward: 0, verifier: { outcome: 'failed' } },
 {
 label: 'non-array-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: 'not-an-array' },
 },
 {
 label: 'sparse-attempts',
 reward: 0,
 verifier: { outcome: 'failed', attempts: sparseAttempts },
 },
 {
 label: 'reward-disagreement',
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 ] as const) {
 const result = await runFixedPromptController({
 runId: `run-${label}`,
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, `results-${label}.jsonl`),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward,
 status: 'failed',
 errorClass: 'max_tokens',
 verifier: verifier as unknown as TaskRunOutput['harbor']['verifier'],
 }),
 });

 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'max_tokens');
 }
 });
 });

 test('rejects a sparse verifier attempt array as provider infrastructure output', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const attempts = new Array(2) as NonNullable<TaskRunOutput['harbor']['verifier']>['attempts'];
 attempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 const result = await runFixedPromptController({
 runId: 'run-1',
 roundId: 'round-1',
 config,
 systemPromptPath,
 resultsJsonlPath: join(dir, 'results.jsonl'),
 tasks: [{ id: 'task-a', path: '/bench/task-a' }],
 taskRunner: async () =>
 harborOutput({
 taskId: 'task-a',
 reward: 0,
 status: 'failed',
 errorClass: 'network',
 verifier: { outcome: 'failed', attempts },
 }),
 });

 assert.equal(result.events[0]?.type, 'task_infra_failed');
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'network');
 });
 });

 test('projects a stored structured verifier failure without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand All@@ -3198,7 +3295,7 @@ describe('fixed prompt controller', () => {
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'runtime_error',
 errorClass: 'infra_failed',
 harbor: {
 reward: 0,
 verifier: {
Expand DownExpand Up@@ -3231,14 +3328,32 @@ describe('fixed prompt controller', () => {
 });
 });

 test('keeps malformed stored verifier attempts on the ungraded path', async () => {
 test('reprojects stale fallback scores when stored verifier data is rejected', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
 await writeFile(systemPromptPath, 'fixed prompt\n', 'utf8');
 const sparseAttempts = new Array(2);
 sparseAttempts[1] = {
 attempt: 2,
 classification: 'failed',
 durationMs: 20,
 reward: 0,
 };

 for (const [label, verifier] of [
 ['missing', { outcome: 'failed' }],
 ['non-array', { outcome: 'failed', attempts: 'not-an-array' }],
 for (const [label, reward, verifier, errorClass] of [
 ['missing-attempts', 0, { outcome: 'failed' }, 'max_tokens'],
 ['non-array-attempts', 0, { outcome: 'failed', attempts: 'not-an-array' }, 'max_tokens'],
 ['sparse-attempts', 0, { outcome: 'failed', attempts: sparseAttempts }, 'max_tokens'],
 [
 'reward-disagreement',
 1,
 {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 'max_tokens',
 ],
 ['policy-denied', 0, { outcome: 'failed' }, 'policy_denied'],
 ] as const) {
 const resultsJsonlPath = join(dir, `results-${label}.jsonl`);
 const stored = taskCompletedEvent({ taskId: 'task-a' });
Expand All@@ -3250,10 +3365,10 @@ describe('fixed prompt controller', () => {
 ...stored,
 status: 'failed',
 passed: false,
 scored: false,
 eligible: false,
 errorClass: 'infra_failed',
 harbor: { reward: 0, verifier },
 scored: true,
 eligible: true,
 errorClass,
 harbor: { reward, verifier },
 })}\n`,
 'utf8',
 );
Expand All@@ -3274,13 +3389,152 @@ describe('fixed prompt controller', () => {

 assert.equal(runnerCalls, 0);
 assert.equal(result.events[0]?.type, 'task_completed');
 assert.equal(result.events[0]?.passed, false);
 assert.equal(result.events[0]?.scored, false);
 assert.equal(result.events[0]?.eligible, false);
 assert.equal(result.events[0]?.errorClass, 'infra_failed');
 assert.equal(result.events[0]?.errorClass, errorClass);
 }
 });
 });

 test('removes a stale pass from rejected legacy verifier output', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const stored = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(stored.type, 'task_completed');
 if (stored.type !== 'task_completed') throw new Error('expected completed fixture');
 const { errorClass: _storedErrorClass, ...legacy } = stored;
 await writeFile(
 resultsJsonlPath,
 `${JSON.stringify({
 ...legacy,
 status: 'failed',
 passed: true,
 scored: true,
 eligible: true,
 harbor: {
 reward: 1,
 verifier: {
 outcome: 'failed',
 attempts: [{ attempt: 1, classification: 'failed', durationMs: 20, reward: 0 }],
 },
 },
 })}\n`,
 'utf8',
 );

 const [projected] = await readFixedPromptWal(resultsJsonlPath);

 assert.equal(projected?.type, 'task_completed');
 assert.equal(projected?.passed, false);
 assert.equal(projected?.scored, false);
 assert.equal(projected?.eligible, false);
 assert.equal(projected?.errorClass, 'verification_failed');
 });
 });

 test('preserves non-verifier scoring authorities while projecting stored WAL', async () => {
 await withDir(async (dir) => {
 const resultsJsonlPath = join(dir, 'results.jsonl');
 const base = taskCompletedEvent({ taskId: 'task-a' });
 assert.equal(base.type, 'task_completed');
 if (base.type !== 'task_completed') throw new Error('expected completed fixture');
 const malformedVerifier = { outcome: 'failed' };
 await writeFile(
 resultsJsonlPath,
 [
 {
 ...base,
 id: 'tool-step-cap',
 taskId: 'tool-step-cap',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'deadline',
 taskId: 'deadline',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 deadlineSettlement: { source: 'benchmark.deadline', mode: 'immediate' },
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'completed',
 taskId: 'completed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 harbor: { reward: 0, verifier: malformedVerifier },
 },
 {
 ...base,
 id: 'no-verifier',
 taskId: 'no-verifier',
 status: 'failed',
 passed: false,
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 harbor: { reward: 0 },
 },
 ]
 .map((event) => JSON.stringify(event))
 .join('\n') + '\n',
 'utf8',
 );

 const projected = await readFixedPromptWal(resultsJsonlPath);
 assert.deepEqual(
 projected.map((event) => {
 assert.equal(event.type, 'task_completed');
 if (event.type !== 'task_completed') throw new Error('expected completed event');
 return {
 taskId: event.taskId,
 scored: event.scored,
 eligible: event.eligible,
 errorClass: event.errorClass,
 };
 }),
 [
 {
 taskId: 'tool-step-cap',
 scored: false,
 eligible: true,
 errorClass: 'tool_step_cap_reached',
 },
 {
 taskId: 'deadline',
 scored: true,
 eligible: true,
 errorClass: 'budget_exhausted',
 },
 {
 taskId: 'completed',
 scored: true,
 eligible: true,
 errorClass: 'verification_failed',
 },
 {
 taskId: 'no-verifier',
 scored: true,
 eligible: true,
 errorClass: 'max_tokens',
 },
 ],
 );
 });
 });

 test('projects a stored structured verifier pass without resampling Harbor', async () => {
 await withDir(async (dir) => {
 const systemPromptPath = join(dir, 'system_prompt.md');
Expand Down
Loading
Loading