Uh oh!
There was an error while loading. Please reload this page.
storage: define session bundle codec contract - #1697
Conversation
Astro-Han
left a comment
There was a problem hiding this comment.
Overall, this is a well-scoped implementation of the Session Bundle codec contract and canonicalization primitives. The responsibility boundary is clear, the manifest and canonical-tree golden tests use independent fixtures, and the dependency contract correctly keeps these primitives isolated from Maka state semantics.\n\nOne non-blocking follow-up: validates with , but reconstructs the envelope using a normal property read. An inherited value (for example after prototype pollution) can therefore be serialized as provenance even though it was not an own JSON member. Please gate the returned optional field with the same check and add an inherited-property regression test.\n\nThis is low severity and does not need to block this PR; it should be addressed before untrusted callers are wired into the encoder or as part of the next Session Bundle codec PR.
Astro-Han
commented
Jul 31, 2026
Correction to my approval review: the inline code identifiers were stripped by shell formatting. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Implements PR 1 of the Session Bundle filesystem codec defined in #1528.
This establishes the portable, state-schema-independent contract and deterministic canonicalization primitives that the streaming archive implementation will build on.
What changed
Tests
All checks pass on the latest main.
Part of #1528.