Uh oh!
There was an error while loading. Please reload this page.
test(e2e): drop stale first-run needs_connection tests - #1725
Merged
Conversation
#1720 (opencode-free as a zero-credential default provider) added `ensureBootstrapConnection`, which unconditionally seeds an `opencode-free` connection on first launch when no connections exist. The E2E gate that skips it, `if (!e2eFixture)`, only triggers when `MAKA_E2E_FIXTURE` is set, but the `emptyWindow` fixture (used by all four `first-run.spec.ts` tests) passes `seed: false` and no `e2eFixtureScenario`, so `MAKA_E2E_FIXTURE` is unset and the bootstrap runs — seeding `opencode-free` into the "empty" workspace. The onboarding state becomes `ready_empty` instead of `needs_connection`, so `OnboardingHero` no longer renders `.maka-firstrun-row`, and the four tests fail with `toHaveCount 0` / click timeouts. This is a deterministic regression on current main (not a flake): #1720's own e2e failed exactly these four; every post-#1720 run fails them identically; pre-#1720 runs passed. #1720 merged with the failing e2e, so every PR's e2e is now red on these four. The `needs_connection` first-run hero is now unreachable for a fresh install (opencode-free is always seeded, and re-seeded whenever the connection list is empty), so these tests assert a contract that no longer holds. Drop them now to unblock e2e; follow-up will add coverage for the post-#1720 fresh-install boot contract (opencode-free seeded -> ready_empty). Also remove the now-unused `emptyWindow` fixture (it was "Used by first-run only"). Unblocks the plan-reminder focus-restore fix (#1723) and the docs PR #1719, whose e2e runs merge with main and so also hit this cluster. Verified: `npx playwright test --list` parses the remaining 93 tests across 32 files with no import/syntax errors; `emptyWindow` has no remaining references. The 93 remaining tests passed in the CI runs that failed only on these four.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1720 (opencode-free as a zero-credential default provider) added
ensureBootstrapConnection, which unconditionally seeds anopencode-freeconnection on first launch when no connections exist. The E2E gate that skips it,if (!e2eFixture), only triggers whenMAKA_E2E_FIXTUREis set, but theemptyWindowfixture (used by all fourfirst-run.spec.tstests) passesseed: falseand noe2eFixtureScenario, soMAKA_E2E_FIXTUREis unset and the bootstrap runs — seedingopencode-freeinto the "empty" workspace. The onboarding state becomesready_emptyinstead ofneeds_connection, soOnboardingHerono longer renders.maka-firstrun-row, and the four tests fail withtoHaveCount 0/ click timeouts.This is a deterministic regression on current main (not a flake): #1720's own e2e failed exactly these four; every post-#1720 run fails them identically; pre-#1720 runs passed. #1720 merged with the failing e2e, so every PR's e2e is now red on these four.
The
needs_connectionfirst-run hero is now unreachable for a fresh install (opencode-free is always seeded, and re-seeded whenever the connection list is empty), so these tests assert a contract that no longer holds. Drop them now to unblock e2e. Follow-up will add coverage for the post-#1720 fresh-install boot contract (opencode-free seeded -> ready_empty). The now-unusedemptyWindowfixture ("Used by first-run only") is removed too.Unblocks the plan-reminder focus-restore fix (#1723) and the docs PR #1719, whose e2e runs merge with main and so also hit this cluster.
Verification
npx playwright test --list --config e2e/playwright.config.ts: parses the remaining 93 tests across 32 files with no import/syntax errors.emptyWindowhas no remaining references across the repo.Review focus
This drops test coverage of the
needs_connectionfirst-run hero to unblock CI. The follow-up (tracked separately) should add E2E for the new fresh-install boot contract. If the team instead wants to keep exercising theneeds_connectionhero, the alternative is to gateensureBootstrapConnectionin E2E (e.g., skip it whenisE2e/isIsolatedE2e, not only whene2eFixture) soemptyWindowboots without opencode-free — say so and I'll switch the approach.