Uh oh!
There was an error while loading. Please reload this page.
refactor: migrate shell navigation to Astryx - #1729
Closed
Astro-Han wants to merge 4 commits into
Closed
Conversation
jackwener
commented
Aug 1, 2026
Member
Superseded by #1732, which landed the same AppShell/SideNav, List/TreeList, workbar TabList, and real-shell Storybook migration from the same base, plus the follow-up focus/inset/E2E fixes. Rebasing this older alternate implementation would regress the merged official-shell result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppShellandSideNavwhile preserving Maka's titlebar drag regions, resize/collapse behavior, routing, and narrow-window controls.List/Itemand project navigation toTreeList, removing parallel arrow-key and expansion ownership. Session rename remains menu-owned and now contains Home/End/Arrow keys inside the editor.TabList/Tabnavigation while preserving dock persistence, browser keep-alive, disabled-state guards, and responsive right/bottom placement.Verification
npm run format:checknpm run lintnpm run typechecknpm test --workspace @maka/uinpm test --workspace @maka/desktop(2012 tests passed)npm test --workspace @maka/runtime(full suite passed, including the POSIX cancellation timing case)npm run buildnpm run build-storybook --workspace @maka/desktopnpm run smoke:storybook --workspace @maka/desktop(27 renderer/play checks passed)npx playwright test --config e2e/playwright.config.ts e2e/project-management.spec.ts e2e/sidebar-geometry.spec.ts e2e/sidebar-navigation.spec.ts e2e/session-workbar.spec.ts e2e/topbar-overflow.spec.ts e2e/window-titlebar.spec.ts(13 passed)Review focus
mobileNav.breakpointis explicitlynone: Astryx 0.1.9 otherwise applies its default responsive breakpoint even whenmobileNavis false, which would bypass Maka's existing narrow sidebar controls.hidden, preserving terminal/browser state when switching tabs.