Uh oh!
There was an error while loading. Please reload this page.
fix(headless): classify incomplete terminal provider streams under Pier - #1762
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge external review of #1758 found that
d783aa3a4's terminal-provider-stream classification only exists in the Harbor runner: a Pier trial whose last proxied provider request endsinterrupted/failed/aborted(a 200 stream without its protocol terminal event = incomplete provider response) still reads the verifier reward and can record a graded model failure where Harbor throws infra. This ports the semantic to the Pier runner.incompleteTerminalProviderRequestinharbor-task-runner.ts(the module both runners already import shared helpers from); Harbor's behavior is byte-identicalpier-task-runner.tsthrowsPierInfraError('infra_failed', telemetry artifact attached) at the same point in its flow — after the exit-code check, before reading the rewardVerification
interruptedmust throw,completedmust take the reward path (the proxy's recording of truncated streams is already covered by the Harbor live-SSE test on the shared proxy machinery)packages/headlesssuite: 1456 pass / 0 fail;format/lintcleanReview focus
The timed-out-trial exemption is shared with Harbor: complete timed-out trials settle by deadline, so their truncated tail request is expected.