Uh oh!
There was an error while loading. Please reload this page.
fix(runtime): add gateway to InvocationSource - #1856
Merged
Conversation
#1587 sets runtimeSource to gateway for cloud activation, but the INVOCATION_SOURCES union never included it, so typecheck and unit build of packages/cli failed after merge with main.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1587 sets
runtimeSource: 'gateway'for one-shot Cloud Session activation, butINVOCATION_SOURCESonly alloweddesktop | bot | test. After the merge,packages/clifailed typecheck/build on main (TS2322).Add
gatewayto the union so activation can label invocations correctly. Refs #1587.Verification
npm --workspace @maka/runtime run build— passnpm --workspace maka-agent run build(the packages that failed on main CI) — passnpm run format:check— passnpm run lint— pass