fix: repair CI broken by #1880 (format + platform-independent e2e signal) by Astro-Han · Pull Request #1887 · apache/maka

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han · 2026-08-02T06:38:43Z

Summary

PR #1880 merged with its own CI red, breaking main (run 30734948700). Both failures come from #1880's changes:

typecheck job: scripts/check-console.mjs — the new main.ts allow-list entry exceeded the line width and was never formatted (npm run format:check fails).
e2e job: the new storage-root-conflict.spec.ts regression test treats "CDP evaluate never settles within 1s" as proof the repair dialog is open. That holds only on macOS, where modal loops block CDP evaluation; on Linux CI the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process (the exact regression the test guards) would have been accepted as a pass on Linux. The signal is fundamentally platform-dependent: macOS and Linux modal dialogs behave oppositely under CDP evaluation, so no evaluate-based heuristic can be portable.

Fix: replace the heuristic with an explicit contract. boot.ts prints [storage-root] root-identity conflict; parking at repair dialog synchronously before the modal — only reachable after ready and only when the root-identity gate fired — and the test waits for that console event (Playwright forwards main-process console via CDP). The workspace write-free assertion is unchanged. Deadlock and gate-removal never print the signal, so both still fail the test on every platform.

Also: main has no branch protection (404 on the protection API), which is why #1880 could merge with red checks.

Verification

npm run format:check — clean (1381 files)
npm run lint — clean (2252 files)
npm run typecheck — clean (all workspaces)
Full desktop e2e: 73 passed, including the rewritten storage-root-conflict test (macOS, 5.5s)
RED check: removing the boot log line makes the test fail (signal missing → fail), confirming the test still catches gate absence/deadlock
The decisive Linux behavior is verified by this PR's own CI run, which failed on main and must now pass

The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

The regression test for the ESM startup deadlock treated 'CDP evaluate never settles within 1s' as the proof that the repair dialog was open. That holds only on macOS, where modal loops block CDP evaluation; on Linux (CI) the modal keeps answering evaluation, so the test failed even though the app parked correctly — and a deadlocked main process would have been accepted as a pass. Replace the heuristic with an explicit contract: boot.ts prints '[storage-root] root-identity conflict; parking at repair dialog' synchronously before the modal (printed only after ready, only when the gate fired), and the test waits for that console event. The workspace write-free assertion is unchanged. Deadlock and gate-removal both never print the signal, so both still fail the test on every platform.

Astro-Han added 2 commits August 2, 2026 14:38

fix(scripts): format check-console allow-list entry
a2d5fe4
The PR1880 entry for main.ts exceeded the line width; biome format required splitting it. format:check was failing CI on main.

Astro-Han marked this pull request as ready for review August 2, 2026 06:45