fix(desktop): make macOS dev permission grants reliable by liugddx · Pull Request #1920 · apache/maka

apps/desktop/README.md

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,44 @@ @@
 The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`.
+## macOS development permissions
+`npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed
+`apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC
+retain Accessibility and Screen Recording grants while renderer and main-process
+code change. The generated app is ignored by Git and is rebuilt automatically
+when the installed Electron version changes. Run
+`npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly.
+The scripts launch the bundle through macOS LaunchServices rather than executing
+its internal binary from a terminal. This is required for TCC to attribute the
+running process to `Maka Dev` and recognize the stored grants.
+The launcher remains alive as the development-session supervisor until the
+terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local
+bootstrap that reads a PID-validated, per-worktree session file, restoring the
+Vite URL and a curated environment-variable allowlist before importing the main
+process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect
+to the same HMR session without relying on command-line arguments that the
+system restart discards. Session files live in the ignored
+`apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle,
+and are written atomically with mode `0600`. Startup is acknowledged only after
+the single-instance lock and main-process boot succeed; failures and timeouts are
+reported in the terminal instead of leaving a windowless supervisor running.
+The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`.
+This keeps development isolated from the packaged Maka profile and lets separate
+worktrees run concurrently. An explicit `--user-data-dir` still takes precedence.
+Only one supervised Maka Dev session can use a worktree at a time. Runtime
+preparation is protected by a PID lock, and shutdown targets the app PID recorded
+by that supervisor rather than every process sharing the development bundle ID.
+Runtime rebuilds refuse to proceed while that worktree has a live supervisor.
+Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording
+changes require restarting the development app. Recreating the app or changing
+its Electron version may require granting permissions again. Other platforms
+continue to use their normal Electron development executable.
 ## Three layers
 | Layer | Path | Role |
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,8 @@ @@
  "type": "module",
  "main": "dist/main/main.js",
  "scripts": {
- "start": "electron .",
+ "start": "node scripts/start-dev-app.mjs",
+ "prepare:dev-app": "node scripts/prepare-dev-app.mjs",
  "dev": "node scripts/dev.mjs",
  "dev:hmr": "node scripts/dev.mjs",
  "storybook": "storybook dev -p 6006 -c .storybook",
@@ Expand DownExpand Up / @@ -58,6 +59,7 @@ @@
  },
  "devDependencies": {
  "@ant-design/icons-svg": "4.5.0",
+ "@electron/asar": "3.4.1",
  "@fontsource-variable/geist": "^5.2.9",
  "@fontsource-variable/geist-mono": "^5.2.8",
  "@playwright/test": "^1.61.1",
@@ Expand Down @@

blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /makaPublic Notifications You must be signed in to change notification settings Fork 415 Star 4.5k Code Issues237 Pull requests169 Discussions Actions Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Security and quality Insights fix(desktop): make macOS dev permission grants reliable#1920 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged Astro-Han merged 11 commits into apache:main from liugddx:fix/dev-permission-overlay-native-icon-crashAug 3, 2026 Conversation 7 Commits 11 Checks 11 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix(desktop): make macOS dev permission grants reliable #1920 Show file tree Hide file tree Changes from all commits Commits Show all changes 11 commits Select commit Hold shift + click to select a range 0f1f7a1 fix(desktop): avoid dev permission icon crash liugddx Aug 2, 20264e26c3b feat(desktop): add stable macOS dev app identity liugddx Aug 2, 2026c841d71 fix(desktop): complete macOS dev permission flow liugddx Aug 2, 202682b19c7 fix(desktop): preserve dev session across TCC restart liugddx Aug 3, 202636efa41 fix: satisfy biome format gate on knip.json Aug 3, 20268f3e1d1 fix(desktop): harden dev app runtime against pid/session races and si… Aug 3, 202695e2324 Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 20268973abd fix(desktop): harden macOS dev supervision liugddx Aug 3, 20264de1677 Merge remote-tracking branch 'origin/fix/dev-permission-overlay-nativ… liugddx Aug 3, 2026f282139 fix(scripts): keep legacy bundle measurement importable liugddx Aug 3, 202641bb84b Merge remote-tracking branch 'upstream/main' into fix/dev-permission-… liugddx Aug 3, 2026 File filter Filter by extension Filter by extension .json (4) .md (1) .mjs (6) .ts (8) dotfile (1) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace apps/desktop/.gitignore .gitignore apps/desktop/README.md README.md apps/desktop/package.json package.json apps/desktop/scripts/dev-app-runtime.mjs dev-app-runtime.mjs apps/desktop/scripts/dev-app-runtime.test.mjs dev-app-runtime.test.mjs apps/desktop/scripts/dev.mjs dev.mjs apps/desktop/scripts/prepare-dev-app.mjs prepare-dev-app.mjs apps/desktop/scripts/start-dev-app.mjs start-dev-app.mjs apps/desktop/src/main/__tests__/os-permission-policy.test.ts os-permission-policy.test.ts apps/desktop/src/main/__tests__/permission-overlay-controller.test.ts permission-overlay-controller.test.ts apps/desktop/src/main/main.ts main.ts apps/desktop/src/main/os-permission-policy.ts os-permission-policy.ts apps/desktop/src/main/permission-overlay/app-bundle.ts app-bundle.ts apps/desktop/src/main/permission-overlay/permission-overlay-controller.ts permission-overlay-controller.ts apps/desktop/src/main/permission-overlay/permission-overlay-main.ts permission-overlay-main.ts apps/desktop/src/main/permissions-actions.ts permissions-actions.ts knip.json knip.json package-lock.json package-lock.json package.json package.json scripts/measure-session-bundle.mjs measure-session-bundle.mjs There are no files selected for viewing 2 changes: 2 additions & 0 deletions 2 apps/desktop/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -1,3 +1,5 @@ # Playwright E2E run artifacts: traces, videos, screenshots, last-run state. test-results/ resources/workers/ .maka-dev/ .maka-dev-session/ 38 changes: 38 additions & 0 deletions 38 apps/desktop/README.md Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -2,6 +2,44 @@ The Electron desktop app: `main` (Node/Electron main process) + `preload` (context bridge) + `renderer` (React UI). This file covers the three-layer split and the IPC contract. For build/test commands and the test-layer selection guide, see the top-level `README.md`; for the renderer interior, see `src/renderer/README.md`. ## macOS development permissions `npm run dev` and `npm start` launch macOS development builds through a generated, ad-hoc-signed `apps/desktop/.maka-dev/Maka Dev.app`. The stable bundle identity lets macOS TCC retain Accessibility and Screen Recording grants while renderer and main-process code change. The generated app is ignored by Git and is rebuilt automatically when the installed Electron version changes. Run `npm --workspace @maka/desktop run prepare:dev-app` to prepare it explicitly. The scripts launch the bundle through macOS LaunchServices rather than executing its internal binary from a terminal. This is required for TCC to attribute the running process to `Maka Dev` and recognize the stored grants. The launcher remains alive as the development-session supervisor until the terminal receives Ctrl-C or SIGTERM. The generated bundle contains a small local bootstrap that reads a PID-validated, per-worktree session file, restoring the Vite URL and a curated environment-variable allowlist before importing the main process. macOS's Screen Recording “Quit & Reopen” action can therefore reconnect to the same HMR session without relying on command-line arguments that the system restart discards. Session files live in the ignored `apps/desktop/.maka-dev-session/` directory, outside the rebuildable app bundle, and are written atomically with mode `0600`. Startup is acknowledged only after the single-instance lock and main-process boot succeed; failures and timeouts are reported in the terminal instead of leaving a windowless supervisor running. The default profile is `~/Library/Application Support/Maka Dev-<worktree-id>`. This keeps development isolated from the packaged Maka profile and lets separate worktrees run concurrently. An explicit `--user-data-dir` still takes precedence. Only one supervised Maka Dev session can use a worktree at a time. Runtime preparation is protected by a PID lock, and shutdown targets the app PID recorded by that supervisor rather than every process sharing the development bundle ID. Runtime rebuilds refuse to proceed while that worktree has a live supervisor. Grant permissions to **Maka Dev**, not a generic Electron entry. Screen Recording changes require restarting the development app. Recreating the app or changing its Electron version may require granting permissions again. Other platforms continue to use their normal Electron development executable. ## Three layers | Layer | Path | Role | Expand Down 4 changes: 3 additions & 1 deletion 4 apps/desktop/package.json Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -9,7 +9,8 @@ "type": "module", "main": "dist/main/main.js", "scripts": { "start": "electron .", "start": "node scripts/start-dev-app.mjs", "prepare:dev-app": "node scripts/prepare-dev-app.mjs", "dev": "node scripts/dev.mjs", "dev:hmr": "node scripts/dev.mjs", "storybook": "storybook dev -p 6006 -c .storybook", Expand DownExpand Up @@ -58,6 +59,7 @@ }, "devDependencies": { "@ant-design/icons-svg": "4.5.0", "@electron/asar": "3.4.1", "@fontsource-variable/geist": "^5.2.9", "@fontsource-variable/geist-mono": "^5.2.8", "@playwright/test": "^1.61.1", Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.