refactor(ui): simplify the Skills page on Astryx

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.

[me2seeks]

Summary

• replace the promotional/card stack and hand-built Skill rows with Astryx Item surfaces
• keep one direct Use action and one state switch per installed Skill, with open, pin, update, and delete in a single contextual menu
• keep source and scope as inline supporting metadata, reduce skills.css from 618 to 258 lines, and add the requested Storybook states plus UI/Desktop coverage

Rationale

The page gave promotional content, discovery, context diagnostics, and every row action similar visual weight. This makes discovery and installed management easier to scan while preserving source import, installation, update review, enablement, pinning, deletion, file opening, and explicit invocation.

This is rebased onto current main and does not restore the removed sample-Skill action. The remaining page-level open-folder and refresh actions move into one secondary menu.

Verification

• npm --workspace @maka/ui test — 321 passed
• npm --workspace @maka/desktop run typecheck:stories
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 68 manifest checks and 78 catalog renders passed
• npm --workspace @maka/desktop run test:checks
• workspace dependency build across core, storage, MCP, runtime, runtime host, computer use, and UI
• Storybook annotation and visual-smoke harness tests — 9 passed
• targeted Playwright collection — 3 tests across the Skills hierarchy and scope-aware deletion journeys
• committed update-review Storybook journey opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments

The committed Playwright specs use normal pointer interactions. The update-review journey also runs through the real Astryx menu layer in the Storybook browser smoke rather than asserting static menu text only.

Closes#1901

中文说明

• 使用 Astryx Item 重组市场、内置和已安装 Skill 列表，移除促销区与重复的卡片框架。
• 每个已安装 Skill 只保留一个直接“使用”动作和一个启停开关；打开、固定、更新、删除收进同一个更多菜单。
• 来源与作用域改为行内辅助信息，skills.css 从 618 行缩减到 258 行，并补齐空列表、已安装、内置、可更新、已停用和窄窗口 Storybook 场景及相关测试。
• 新增可更新场景的真实交互测试：打开行菜单与差异面板、应用来源版本，并校验传入更新回调的 current/source SHA。
• 本分支已重放到最新主线，不会重新引入已删除的“创建示例 Skill”入口。

[me2seeks]

The Skills-specific checks are passing. Storybook covered the installed view at wide, compact, and floor sizes, along with all five new catalog states. All three Skills E2E tests also passed in shard 2.

The red checks come from the Settings changes in #1972: Storybook fails on daily-review-model-selector-open-narrow, and shard 2 fails only on e2e/settings.spec.ts while focusing the theme radio group. #1972 has the same failures in its own CI run, and the aggregate e2e check simply reflects the shard result.

[Astro-Han]

Review: MERGE-READY ✅ (2 independent deepseek-v4-flash passes)

Reviewed the full diff (+564/−703, 9 files), ran the UI suite, and verified the Astryx contracts.

• Feature parity preserved: install (market/built-in), import sources, enable/disable, direct Use, open SKILL.md, pin, update review, delete (now modal-confirm — safer than the old two-stage timer), refresh, open directory, context check, search/filter/sort, empty state, slug-collision display, exception badge, actionBusy guard — all retained; only the promo banner (removed per #1901) and row hover background were dropped.
• Astryx className pitfall checked and clear: Item/DropdownMenuItem append consumer className/style via mergePropsafter internal stylex classes (no replace-semantics trap, unlike the pattern that broke #1738's search input).
• Deletion is clean: the 3 removed CSS tokens and 7 removed copy keys have zero remaining consumers repo-wide (verified by grep); new CSS classes all have consumers; check-story-annotations passes.
• Tests verified: new skills-panel.test.tsx (4 cases) passes; whole @maka/ui suite 272/272 green; rewritten skill-delete-scope.spec.ts + new skills.spec.ts aria/role assertions match Astryx's real DOM contracts. No "lying" old tests.
• State discipline improved: timer-based delete-confirm effect (which violated the repo's "Effects only for external sync" convention) removed in favor of event-handler-driven dialog flow.

P2 to handle or explicitly defer: the update-review render journey (menu item → diff panel → apply) was rewritten but has zero committed test coverage (existing tests stop at menuitem existence; no story opens the UPDATE_AVAILABLE_PREVIEW fixture; PR body notes only manual exercise). Recommend adding one render test asserting the review panel opens and "update to source" calls onUpdateManagedSkill with the right sha, or record an explicit deferral.

Non-blocking P3: duplicate rAF-delay helper (skills-panel.tsx:112 vs :781); no in-progress indicator during delete; hover tooltip narrowed to label; hidden .maka-skill-tool-summary-hidden span retained.

Merge prerequisites: (1) the branch is ~100 commits behind main (merge-base 8e5008e vs main 1caea26; GitHub reports MERGEABLE) — CI evidence ran against the old base, so please rebase onto latest main and re-run CI; (2) the existing reds on the old base (settings theme focus flake, daily-review storybook contract) are unrelated to this PR and should disappear on a fresh run.

[me2seeks]

Rebased this onto current main (bc12cddf) and added the missing update-review render journey in 26dc5a81. The Storybook play now opens the row menu and diff panel, applies the source update, and asserts the exact current/source SHA arguments. All fresh checks are green (9 passed, 2 skipped by path). @Astro-Han, when you have a moment, could you take another look?

[Astro-Han]

LGTM! merging.