fix: restore CI after the settings rows-kit rebuild

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.

[Astro-Han]

Summary

storybook and e2e_shard have both been red on main since #1972. Both failures are fallout from that rebuild rather than problems with what it produced, and neither is a product defect — theme switching and the Daily Review layout both work.

1. Storybook — the contract could not find its own elements.

[product-settings-pages--daily-review-model-selector-open-narrow @ floor]
Error: Daily Review bounds contract could not resolve its production elements

#1972 retired .settingsFormLayout — grep -r settingsFormLayout apps/desktop/src now returns nothing. The contract still resolved its row containers through closest('.settingsFormLayout'), so timeForm and selectorForm were unconditionally null and the guard threw before asserting any bound. A control now sits in its row's capped end slot (SettingsRow renders end inside <span className="settingsRowEnd">, which settings-section.tsx documents as the slot that "caps" the control), so .settingsRowEnd is the container this contract has always meant. Every assertion is unchanged, and they now run for the first time since #1972 — passing at both floor and catalog.

2. E2E — the theme journey drove roles the picker no longer has.

TimeoutError: locator.focus: Timeout 30000ms exceeded.
- waiting for getByRole('radiogroup', { name: '主题' }).getByRole('radio', { name: '浅色' })

#1972 rebuilt the theme picker on Astryx SelectableCard. That matches the component's own @compositionHint ("single-select card groups... radio-style selection"), but SelectableCard's accessible control is a visually-hidden <input type="checkbox"> and the library ships no radio variant — so the group exposes no radiogroup, and no radio children.

A probe against the built app confirmed the split:

Theme switching works	yes — Space on 深色 checks it and html.dark flips
radiogroup "主题"	absent (count = 0)
Option roles	independent checkbox
ArrowDown within the group	no longer moves selection or focus

Settings is mid-rewrite, so re-pinning this journey to whichever roles the picker happens to expose today buys a contract that is expected to move again. This removes it. The remaining remote access journey in the same file still covers settings open → navigate → mutate.

Refs #1972.

Verification

• npm --workspace @maka/desktop run smoke:storybook — Product Storybook smoke passed (67 manifest check(s), 70 catalog render(s)). This is the command the storybook job runs, and the one that reported 2 story check(s) failed before this change.
• npx playwright test --config e2e/playwright.config.ts — 57 passed (37.3s), full suite, no other spec affected.
• npm run lint (2281 files) and npm run format:check (1416 files) — clean.
• npm --workspace @maka/desktop run typecheck — clean, including tsconfig.storybook.json.

Review focus

The dropped spec is a deliberate removal, not a re-pin. If the intent is instead to restore radiogroup semantics to the theme picker, that is a product change in appearance-settings-page.tsx and wants its own PR — RadioListItem only offers row layout, so a card grid with real radio semantics needs hand-written markup, which is exactly what #1972 set out to delete.