Uh oh!
There was an error while loading. Please reload this page.
Add DeepSeek context budget diagnostics - #22
Merged
likun666661 merged 2 commits intoJun 16, 2026
Conversation
likun666661force-pushed
the
deepseek-context-budget-phase3
branch
from
June 16, 2026 05:23
0240762 to
20a1e42Comparejackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
Add DeepSeek context budget diagnostics
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
Add DeepSeek context budget diagnostics
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
Add DeepSeek context budget diagnostics
jackwener pushed a commit
that referenced
this pull request
Jun 21, 2026
Add DeepSeek context budget diagnostics
This was referenced Jul 5, 2026
Closed
Astro-Han added a commit
that referenced
this pull request
Jul 5, 2026
…contract
- P2-1: InputGroupInput/Textarea spread props before unstyled and
data-maka-field-chrome so a caller's unstyled={false} cannot re-enable
the inner chrome (would double the border / focus ring). The InputGroup
owns the chrome; the inner control stays bare.
- P2-2: port type="search" WebKit cancel/decoration/results reset into
primitives/input. Main's primitives/input always applied this for
InputGroupInput (search-modal path); the unified Input keeps the
contract for both the @maka/ui Input and InputGroupInput paths.
size/nativeInput/type=file variants audited — no callers in repo
(@maka/ui Input was ui.tsx without these; InputGroupInput never
passed them); removed without a compat layer.
- P3-1: rewrite input-canonical-contract as behavior tests only — no
source regex. Styled/unstyled single element + chrome, InputGroup
force-bare even with unstyled={false}, type="search" webkit reset,
barrel import smoke.
- P3-2: #22 PR10 -> #520 item 22 in comments (the PR流水号 narrative
pointed at the wrong tracker).Astro-Han added a commit
that referenced
this pull request
Jul 6, 2026
… Input (#520 item 22) (#555) * feat(ui): canonical Input/Textarea onto Base UI, retire native ui.tsx Input (#22 PR10) #22 PR10: collapse the dual Input tracks onto one canonical primitives/input.tsx + primitives/textarea.tsx, retiring the native ui.tsx Input/Textarea. - primitives/input.tsx now wraps Base UI's Input primitive with maka's inputClasses styling ported as the default chrome. Stays a single <input> (no span wrapper) so caller CSS targeting `> input` / `input:focus-visible` still matches. unstyled gives the bare form (bareFieldClasses + data-maka-field-chrome="none") for Field/InputGroup embedding. - primitives/textarea.tsx parallel shape: single <textarea> + inputClasses + textarea sizing. Base UI ships no Textarea, so this is a native textarea. Drops the Base UI Field.Control + span wrapper (caller doesn't use Field). - ui.tsx Input, Textarea, inputClasses, bareFieldClasses retired. inputClasses + bareFieldClasses moved into primitives/input.tsx (exported) so number-field keeps its standalone NumberFieldInput chrome. - InputGroup: InputGroupInput/InputGroupTextarea already pass unstyled (inner field bare, InputGroup owns the chrome — no double chrome). InputGroup CSS updated to key off data-slot="input"/"textarea" (the single element) instead of the retired span data-slot="input-control"/"textarea-control"; dropped the span-only `:contents` / `:before:hidden` rules. - index.ts re-exports primitives/input + primitives/textarea as the canonical Input/Textarea; the 44 usages across 9 settings files keep importing from @maka/ui unchanged. - Contracts: new input-canonical-contract (single element, inputClasses token lock, ui.tsx retired, bare-field shape); field-chrome.test rewritten for the unified shape (drops nativeInput/h-8.5/field-sizing-content assertions that pinned the old primitives/input vs ui.tsx divergence); radius-converge inputClasses tier repointed at primitives/input.tsx. Verification: typecheck clean; @maka/ui test 43/43; @maka/desktop test 2069/2069. Screenshot pixel diff vs main: settings-general and settings-bots light/dark 1280 AE=0 (pixel-identical, both contain Input). settings-data 364 px (edge); settings-appearance/daily-review ~9-10K px in a 12px right-edge column (window edge, not input/textarea); settings-memory ~18K px in a large content block (main-branch composer/sidebar commits #510/#511, not this PR). * fix(ui): PR10 review — InputGroup force-bare, search reset, behavior contract - P2-1: InputGroupInput/Textarea spread props before unstyled and data-maka-field-chrome so a caller's unstyled={false} cannot re-enable the inner chrome (would double the border / focus ring). The InputGroup owns the chrome; the inner control stays bare. - P2-2: port type="search" WebKit cancel/decoration/results reset into primitives/input. Main's primitives/input always applied this for InputGroupInput (search-modal path); the unified Input keeps the contract for both the @maka/ui Input and InputGroupInput paths. size/nativeInput/type=file variants audited — no callers in repo (@maka/ui Input was ui.tsx without these; InputGroupInput never passed them); removed without a compat layer. - P3-1: rewrite input-canonical-contract as behavior tests only — no source regex. Styled/unstyled single element + chrome, InputGroup force-bare even with unstyled={false}, type="search" webkit reset, barrel import smoke. - P3-2: #22 PR10 -> #520 item 22 in comments (the PR流水号 narrative pointed at the wrong tracker). * fix(ui): drop redundant data-maka-field-chrome on InputGroup adapters The canonical Input/Textarea already force data-maka-field-chrome="none" when unstyled (the {...props} spread precedes the attribute in both primitives, so a caller cannot override it). The adapter passing it explicitly was a no-op. Drop the redundant attribute; keep unstyled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #19
Summary
promptSegmentsandcontextBudgetdiagnostics through usage events, RuntimeEvents, stored token usage messages, RunTrace, and telemetry logs.npm run cost:deepseek-baseline.256_000estimated prior-history tokens and non-DeepSeek providers staying at32_000, plus env overrides:MAKA_CONTEXT_BUDGET=offMAKA_CONTEXT_HISTORY_BUDGET_TOKENSMAKA_CONTEXT_HISTORY_BUDGET_TURNSMAKA_CONTEXT_MIN_RECENT_TURNSLive DeepSeek Findings
86,456, cache hit64,384, cache miss22,072, estimated cost$0.01047512.61,942, but cache miss rose to36,982, estimated cost$0.01174114; the cap bounded prompt size but disrupted provider cache economics.84,762, cache hit52,864, cache miss31,898, estimated cost$0.01232174; trimming began around turn 8 and still caused a cold miss.256_000as the DeepSeek default so the budget is a long-session guardrail rather than an early cache-disrupting trim. Tighter caps remain explicit env/harness experiments.Verification
npm run typecheck --workspaces --if-presentnpm --workspace @maka/runtime testnpm run test --workspaces --if-present(1399/1399)node --check scripts/deepseek-live-cost-baseline.mjsgit diff --check