Uh oh!
There was an error while loading. Please reload this page.
test(storage): relax bundle export lock timeout - #2385
Merged
Astro-Han merged 1 commit intoAug 7, 2026
Merged
Conversation
Astro-Han
marked this pull request as ready for review
August 7, 2026 04:47
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOTEMPTYRoot cause
On Node 26.5.1,
node:sqliteonline backup takes about 5.0 seconds after the test waits on a child-held Artifact writer lock. The test used the same 5-second operation timeout, so the timeout rejected while bundle export and the queued projection were still completing. Temporary-directory cleanup then raced those operations and often replaced the original timeout withENOTEMPTY.The same scenario completed in about 0.3 seconds on the repository's Node 24 CI runtime. Production code completed successfully on every observed Node 26 run, so this keeps the change at the test watchdog seam rather than changing lock, SQLite, or cleanup behavior.
Verification
ENOTEMPTY, some direct projection timeouts), about 5.4 seconds per runartifact-writer-lock.test, 10/10 passed with--test-concurrency=1artifact-writer-lock.test, 10/10 passed with--test-concurrency=1npm --workspace @maka/storage test, 748 tests, 736 passed, 12 skipped, 0 failednpx biome check packages/storage/src/__tests__/artifact-writer-lock.test.ts