Uh oh!
There was an error while loading. Please reload this page.
test: delete obsolete presentation and helper suites - #2478
Merged
Conversation
Astro-Han
marked this pull request as ready for review
August 8, 2026 05:32
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the aggressive cleanup from #2462 by deleting obsolete tests, orphaned prompt fixtures, and dead test-only APIs across Desktop, Core, Headless, UI, CLI, Computer Use, Runtime, and Runtime Host.
The branch changes 110 files with 13 additions and 8,343 deletions (net -8,330). Removed coverage is dominated by:
Focused validation found one runtime-loaded Harbor config that the static scan had misclassified as orphaned. That active asset was restored; only its source-string mirror test remains deleted.
Knip exposed and this PR also removes:
_detectColorLevelForTestingisTaskRunLocatorWhy this is safe
Unique coverage alone was not treated as a retention reason. The retained suite still protects the active product contracts whose failure cost matches test maintenance: authorization, secrets, persistence, recovery, fail-closed protocols, dependency patches, and external-process lifecycle.
Explicitly retained guards
patches/README.md: AI SDK tool-call tracking, Astryx List accessible naming, grouped diff counts, new-message reset behavior, and blank UA-CH platform fallbackVerification
git diff --check origin/main...HEAD— passednpm run format:check/npm run format— passednpm run lint— passednpx knipcompared with the clean root checkout — no new findings; four existing unused Headless exports are goneCI
All triggered checks passed on the expanded third-pass diff:
typechecktest_workspacestest_headlesstest_runtime_hoste2e_shard (1/2)ande2e_shard (2/2)testande2egatesalignment_auditwindows_baseline (non-blocking)storybookwas correctly skipped because this PR does not change stories.Review focus
Residual risk is intentionally concentrated in presentation regressions, exact helper formatting, provider-list drift, and small cross-platform/toolchain display behavior. Active dependency configs and all explicit security, authority, persistence, recovery, protocol, sandbox, and process-lifecycle guards remain.