Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); test(headless): run ordinary CLI command semantics in process by UncertaintyDeterminesYou4ndMe · Pull Request #2480 · apache/maka · GitHub
Skip to content

test(headless): run ordinary CLI command semantics in process - #2480

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2
Aug 8, 2026
Merged

test(headless): run ordinary CLI command semantics in process#2480
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2387-headless-in-process-v2

Conversation

@UncertaintyDeterminesYou4ndMe

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Part of #2387 (Headless workspace; the CLI workspace is #2476 per the issue's separate-PR requirement).

Problem

The Headless suites started a Node subprocess per assertion for scenarios that only exercise argument validation, task-run business logic, and report verdicts. cli.test.ts was the sharpest case: 11 tests, 20 subprocess launches, 21.8s — each launch paying the full module-graph load of the headless CLI to test semantics that runMakaEvalCli already exposes as an exported Promise<number> router.

Change

No production changes. Every conversion goes through an already-exported entry:

  • cli.test.ts — 10 of 11 tests run through mapLegacyMakaHeadlessArgs + runMakaEvalCli, the same mapping and router the bin runs, with stdout/stderr captured at the process-stream seam and env overrides applied/restored around the call. The non-Headless-root test keeps the real bin route as the representative wiring contract (real exit code, stack-free stderr hygiene).
  • contamination-scan-cli.test.ts — 13 of 14 tests call the script's exported main(argv), with the executable footer's contract mirrored exactly (thrown error → stderr + exit 2, verdict codes returned). The no-argument rejection keeps the real subprocess as representative coverage of the footer itself, including its realpath main-module guard. The --markdown test gains an explicit assert.equal(code, 0) that was previously implicit in execFileAsync not rejecting.
  • New shared helper withCapturedProcessIo swaps and restores the process-wide stream writers; safe for the sequential node:test execution these files use.

An earlier revision of this branch also converted three pre-launch validation tests in harness-ab-cli.test.ts; #2462 deleted that suite on main, so that part is gone after rebase.

Deliberately not converted

  • runtime-policy-ab-cli.test.ts: its single test is the representative subprocess for run-runtime-policy-ab.mjs, whose main() is not exported — adding an export to shave 0.6s is a production touch the saving does not justify.
  • pi-cli-json-transport.test.ts already uses an injected fake child; task-agent-controller/harbor-cell subprocesses are the behavior under test.

Retained process contracts

SuiteReal-subprocess coverage kept
cli.test.tsbin wiring end to end: legacy mapping, exit code, stack-free stderr (1 test / 2 launches)
contamination-scan-cli.test.tsexecutable footer: no-args → exit 2, realpath main-module guard (1 test)

Timing

node --test, same machine, warm build:

filebeforeafterspawns
cli.test.js21.79s13.12s20 → 2
contamination-scan-cli.test.js1.05s0.63s14 → 1

The residual 13s in cli.test.js is dominated by one heavy-task journey (7.4s) whose cost is task-run business logic, not startup tax — visible now that the tax is gone.

Tests pass across 3 consecutive rounds after the rebase onto #2462/#2473; typecheck, biome, and knip are clean (knip delta against baseline: run-contamination-scan.mjs moves from unused to used).

Supersedes #2479: that branch predated the #2462 merge and conflicted with it, so GitHub could not build the PR merge commit and never created check suites — which also explains the "CI never triggered" mystery there (my platform-failure guess in its closing comment was wrong).

cc @Astro-Han

Part of apache#2387. The Headless CLI and contamination-scan suites started a
Node subprocess per assertion for scenarios that only exercise argument
validation, task-run business logic, and report verdicts — semantics
the exported entry points already expose.
- cli.test.ts: 10 of 11 tests now run through mapLegacyMakaHeadlessArgs
+ runMakaEvalCli with stdout/stderr captured at the process-stream
seam and env overrides applied and restored around the call. The
non-Headless-root test keeps the real bin route as the representative
wiring contract (real exit code, stack-free stderr).
- contamination-scan-cli.test.ts: 13 of 14 tests call the script's
exported main(argv), mirroring the executable footer exactly (thrown
error -> stderr + exit 2). The no-argument rejection keeps the real
subprocess as representative coverage of that footer itself,
including its realpath main-module guard.
- New shared helper withCapturedProcessIo swaps and restores the
process-wide stream writers; safe for the sequential node:test runs
these files use.
runtime-policy-ab-cli.test.ts is intentionally untouched: its single
test is the representative subprocess for run-runtime-policy-ab.mjs,
whose main() is not exported, and adding an export to shave 0.6s is
not warranted. (harness-ab-cli.test.ts was part of this change until
apache#2462 deleted that suite on main.)
Timing (node --test, local, warm build):
cli.test.js 21.8s -> 13.1s (spawns 20 -> 2)
contamination-scan-cli.test.js 1.05s -> 0.63s (spawns 14 -> 1)
Tests pass across 3 consecutive rounds.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — the boundary split here looks good. Ordinary Headless CLI semantics now use the existing exported entry points, while executable/footer behavior retains representative subprocess coverage. The shared IO helper is small enough as-is, and the heavy-task journey still protects a distinct two-invocation trace contract.

One non-blocking P3 suggestion:

The contamination-scan subprocess coverage now keeps only the no-argument exit 2 path. It no longer exercises a successfully parsed scan whose verdict must make the real executable exit 1. If the footer later regressed to always exit 0, the in-process verdict tests would still pass.

Keeping one “retrieval signal detected → real subprocess exit 1 + stdout report” case would preserve that fail-closed executable contract. If spawn count matters, one of the two similar Headless CLI error-process launches could be moved in process to offset it.

This does not need to block the PR. The current implementation and CI look sufficient to merge. Thanks!

@Astro-Han
Astro-Han merged commit 56ddb9f into apache:mainAug 8, 2026
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59