test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(storybook): shrink the smoke matrix to its declared checks - #2481

Merged
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix
Aug 8, 2026
Merged

test(storybook): shrink the smoke matrix to its declared checks#2481
Astro-Han merged 1 commit into
apache:mainfrom
UncertaintyDeterminesYou4ndMe:perf/2390-storybook-matrix

Conversation

@UncertaintyDeterminesYou4ndMe

Copy link
Copy Markdown
Contributor

Part of #2390 (Storybook half; the Electron E2E changes follow in a separate PR per the issue).

Problem

The product smoke manifest expanded 22 surfaces into 92 serial page loads, but the assertions do not justify the matrix:

  • Every job runs the same baseline: mount succeeds, no console/page errors, root has content, and (dark jobs) the .dark class + computed color-scheme. Only a surface's declared checks[] add anything beyond that.
  • Nine surfaces declare no checks (onboarding, settings, usage, providers, skills, mcp, mcpMarketplace, mcpEditor, dailyReview) — their compact and floor viewports re-ran exactly the baseline that wide already proves. Same for askUserQuestion.
  • Three checked surfaces ran compact and floor through the same check branch: module-page-inspector branches at 1024px (both compact 820 and floor 480 take the dialog branch), plan-reminder-row's right-alignment check gates on ≥1100px (both skip it), and session-context-layer is one width-agnostic predicate whose distinct narrow behavior (overflow-menu fallback) floor already exercises at the stricter width.

Change

One file: apps/desktop/stories/product-smoke-manifest.json. Every removal goes through the runner's own declared mechanism — the validator fails unless each of the three product viewports is either covered or given a written opt-out reason — so nothing is silently skipped:

  • 9 no-checks surfaces + askUserQuestion → wide only (both color schemes kept: the dark-scheme assertion is a real per-job check)
  • planReminders / planRemindersInspector / sessionContext → wide + floor, compact opted out as the same check branch at a looser width

Untouched: REQUIRED_PRODUCT_SURFACES (all 22 surfaces still present), all checks[], the runner itself, and the full catalog mount sweep — every story in the built index still renders once (100 renders before and after), so 'renders without throwing' coverage is not reduced for any story.

Timing

Local, smoke:storybook after build-storybook, same machine:

manifest jobs (serial)catalog renderswall
before9210043.0s
after4810028.6s (−33%)

The manifest half runs at concurrency 1 (its geometry checks need a quiet page), so it dominates smoke wall time — and is exactly the half this shrinks.

Judgment call for review

The three checked-surface compact opt-outs (planReminders, planRemindersInspector, sessionContext) are the interpretive part: the check code takes the same branch as floor, but the DOM under it differs at 820px. If you weigh 820px as an independent geometry worth mounting, say so and I'll restore those three (matrix 48 → 54; the nine no-checks surfaces are the unambiguous bulk of the win).

cc @Astro-Han

Part of apache#2390 (Storybook half; Electron E2E follows separately per the
issue).
The smoke runner asserts per job: mount + console/pageerror cleanliness
+ scheme application, plus any declared checks[]. Nine surfaces declare
no checks, so their compact and floor viewports re-ran exactly the
baseline assertions that wide already proves — repetition without a
distinct failure signal. Three checked surfaces ran compact and floor
through the same check branch (module-page-inspector branches at
1024px; both are below it), so compact duplicated floor with a looser
width.
Every removal goes through the manifest's own declared mechanism: the
validator requires each of the three product viewports to be covered
or explained, so each dropped viewport carries a written opt-out
reason, in the same style the manifest already uses. Nothing is
silently skipped, REQUIRED_PRODUCT_SURFACES is untouched, and the
full-catalog mount sweep (every story renders once) is unchanged.
- 9 no-checks surfaces + askUserQuestion: wide only
- planReminders / planRemindersInspector / sessionContext: wide + floor,
compact opted out (same check branch as floor at a looser width)
Timing (local, node scripts/storybook-visual-smoke.mjs after
build-storybook): 92 manifest jobs -> 48; wall 43.0s -> 28.6s (-33%).
Catalog renders: 100 before and after. Smoke passes on the reduced
matrix.
@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks — this is a good reduction. The manifest should pay for additional viewport jobs only when those jobs prove a distinct contract.

I do not think the removed floor jobs need to be restored. The affected entries had no geometry checks, so another narrow mount would still pass if overflow, column layout, or containment regressed. Their story states continue to receive the catalog mount sweep. If a narrow layout becomes an important contract, the useful follow-up is a focused geometry assertion rather than restoring a mount-only viewport duplicate.

Two small P3 documentation cleanups:

  • The ask-user-question story comment still says the manifest renders compact and floor variants, but this PR changes it to wide only.
  • The PR description reports 92 → 48 manifest jobs; against this branch's parent manifest, the actual count is 90 → 46.

Neither needs to block the test reduction. The implementation and CI look good to merge. Thanks!

@Astro-Han
Astro-Han merged commit 9205a0f into apache:mainAug 8, 2026
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@UncertaintyDeterminesYou4ndMe@Astro-Han@bekk59