You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
enable the production Artifact publication and owner-death recovery gate on Windows
close fixture-owned Artifact and execution stores before releasing the root lease
use the explicit Runtime Host fixture shutdown protocol for portable graceful teardown
allow a larger Windows cold-start budget for recovery of the seeded Artifact catalog
refresh the Windows skip inventory
Validation
npm --workspace @maka/runtime run build
npm --workspace @maka/runtime-host run build
npm --workspace @maka/runtime-host run typecheck
node --test packages/runtime-host/dist/__tests__/artifact-two-client-uds.test.js (passed twice before rebase and once after rebase on Windows)
npm run windows:inventory
git diff --check
The prerequisite Runtime Host fixture shutdown and deterministic execution-store cleanup changes are available on main through #2492. This PR now contains only the Artifact recovery gate and inventory update.
The reason will be displayed to describe this comment to others. Learn more.
The recovery test exercises the real Runtime Host, IPC, SQLite, filesystem residue, and owner-death boundary, and I found no production correctness issue. The remaining Windows CI-lane coverage gap is non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm --workspace @maka/runtime run buildnpm --workspace @maka/runtime-host run buildnpm --workspace @maka/runtime-host run typechecknode --test packages/runtime-host/dist/__tests__/artifact-two-client-uds.test.js(passed twice before rebase and once after rebase on Windows)npm run windows:inventorygit diff --checkThe prerequisite Runtime Host fixture shutdown and deterministic execution-store cleanup changes are available on
mainthrough #2492. This PR now contains only the Artifact recovery gate and inventory update.Part of #2142