Uh oh!
There was an error while loading. Please reload this page.
fix(ci): run Storybook for UI source changes - #2558
Merged
Merged
Conversation
Astro-Hanforce-pushed
the
fix/storybook-ui-source-surface
branch
from
August 9, 2026 05:56
b653c9b to
592b477CompareAstro-Han
marked this pull request as ready for review
August 9, 2026 06:01
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the Storybook build and smoke job when
packages/ui/src/**orapps/desktop/src/renderer/**changes. Product stories mount both source surfaces, so runtime export and render regressions can break the catalog without touching a story file.The previous catalog-only selector let #2538 add the non-component
ICON_SIZEexport without running the icon catalog, and let #2546 change the Daily Review selector geometry without running its narrow layout contract. A later unrelated full-suite change discovered both failures onmain.Refs #2541
Verification
node --test scripts/ci-test-plan.test.mjsfailed because UI and renderer source changes returnedstorybook=false.node --test scripts/ci-test-plan.test.mjs— 6/6 pass.npx biome check scripts/ci-test-plan.mjs scripts/ci-test-plan.test.mjsDependencies
This draft intentionally exposes the two Storybook failures already present on
main:Checklist
Does this PR entail a change in behavior?