Skip to content

fix(ci): run Storybook for UI source changes - #2558

Merged
Astro-Han merged 1 commit into
mainfrom
fix/storybook-ui-source-surface
Aug 9, 2026
Merged

fix(ci): run Storybook for UI source changes#2558
Astro-Han merged 1 commit into
mainfrom
fix/storybook-ui-source-surface

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

Run the Storybook build and smoke job when packages/ui/src/** or apps/desktop/src/renderer/** changes. Product stories mount both source surfaces, so runtime export and render regressions can break the catalog without touching a story file.

The previous catalog-only selector let #2538 add the non-component ICON_SIZE export without running the icon catalog, and let #2546 change the Daily Review selector geometry without running its narrow layout contract. A later unrelated full-suite change discovered both failures on main.

Refs #2541

Verification

  • RED: node --test scripts/ci-test-plan.test.mjs failed because UI and renderer source changes returned storybook=false.
  • GREEN: node --test scripts/ci-test-plan.test.mjs — 6/6 pass.
  • npx biome check scripts/ci-test-plan.mjs scripts/ci-test-plan.test.mjs

Dependencies

This draft intentionally exposes the two Storybook failures already present on main:

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-Han
Astro-Hanforce-pushed the fix/storybook-ui-source-surface branch from b653c9b to 592b477CompareAugust 9, 2026 05:56
@Astro-Han
Astro-Han marked this pull request as ready for review August 9, 2026 06:01
@Astro-Han
Astro-Han merged commit b35e8d5 into mainAug 9, 2026
12 checks passed
@Astro-Han
Astro-Han deleted the fix/storybook-ui-source-surface branch August 9, 2026 06:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Astro-Han