Skip to content

fix(ci): resolve frontend smoke failures - #2568

Closed
liugddx wants to merge 1 commit into
apache:mainfrom
liugddx:fix/frontend-ci-reds
Closed

fix(ci): resolve frontend smoke failures#2568
liugddx wants to merge 1 commit into
apache:mainfrom
liugddx:fix/frontend-ci-reds

Conversation

@liugddx

@liugddxliugddx commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • exclude the non-component ICON_SIZE registry from the Lucide icon story
  • make the real-drag quote E2E wait for and finalize Chromium's non-empty selection
  • keep the Daily Review control checks scoped to their row slots while treating the viewport as the top-layer popover boundary
  • include element geometry in Daily Review overflow failures

Why

These are the unrelated frontend failures observed while validating #2562. The icon story had a deterministic invalid-component bug. The Daily Review and Quote Companion failures were test-contract/event-ordering defects rather than product regressions.

Verification

  • �iome check on all changed files
  • first clean CI iteration: typecheck, workspace tests, alignment audit, and both E2E shards passed; the enhanced Storybook failure isolated the remaining 2.2px assertion mismatch to a viewport-contained top-layer popover
  • updated clean GitHub CI is running

@liugddx
liugddxforce-pushed the fix/frontend-ci-reds branch from 53be8e8 to b85e21bCompareAugust 9, 2026 05:33
@liugddx

Copy link
Copy Markdown
MemberAuthor

Superseded by #2544 (runtime-safe icon catalog filtering) and #2556 (bounded settings selector menus with diagnostic geometry). Latest main CI run 31297747919 is green across Storybook, both E2E shards, typecheck, workspace tests, and alignment audit, so this conflicting duplicate is no longer needed.

@liugddxliugddx closed this Aug 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@liugddx