Uh oh!
There was an error while loading. Please reload this page.
refactor(css): merge scattered duplicate selector rules (Round B, #253) - #258
Closed
somewan820 wants to merge 1 commit into
Closed
refactor(css): merge scattered duplicate selector rules (Round B, #253)#258somewan820 wants to merge 1 commit into
somewan820 wants to merge 1 commit into
Conversation
…che#253) Merge 9 selectors that had multiple scattered rule blocks into single consolidated blocks: .maka-list-row-main (2→1) .maka-onboarding-quickchat-submit (3→1) .maka-onboarding-ready header (2→1) .maka-onboarding-ready .maka-onboarding-eyebrow (2→1) .maka-plan-tabs-bar (2→1) .maka-plan-compact-select (2→1) .settingsNavItem (2→1) .settingsRow (2→1) .providerActions (2→1) Subsequent block declarations appended to first block's closing brace. CSS cascade semantics preserved — later declarations override earlier same-name properties, computed styles unchanged. Verified via lightningcss minify comparison: 0 real mismatches (1 false positive from lightningcss dead-code elimination where gap:10px subsumes row-gap:10px — computed style identical). No rule, selector, property value, or comment changed — pure block relocation. Comment balance 300/300, brace balance 1889/1889. Part of issue apache#253 Round B.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge 9 selectors that had multiple scattered rule blocks into single consolidated blocks:
.maka-list-row-main (2→1)
.maka-onboarding-quickchat-submit (3→1)
.maka-onboarding-ready header (2→1)
.maka-onboarding-ready .maka-onboarding-eyebrow (2→1)
.maka-plan-tabs-bar (2→1)
.maka-plan-compact-select (2→1)
.settingsNavItem (2→1)
.settingsRow (2→1)
.providerActions (2→1)
Subsequent block declarations appended to first block's closing brace. CSS cascade semantics preserved — later declarations override earlier same-name properties, computed styles unchanged.
Verified via lightningcss minify comparison: 0 real mismatches (1 false positive from lightningcss dead-code elimination where gap:10px subsumes row-gap:10px — computed style identical).
No rule, selector, property value, or comment changed — pure block relocation. Comment balance 300/300, brace balance 1889/1889.
Part of issue #253 Round B.