Uh oh!
There was an error while loading. Please reload this page.
ci: cut wall-clock via impact gates and single e2e job - #2589
Merged
Conversation
- Skip Storybook and Electron e2e for packages/ui (and renderer) unit-test-only paths; keep product-source gates. - Collapse dual e2e shards plus a separate alignment job into one e2e job that reuses install and the built renderer for the CDP audit.
CI format:check rejected the multi-line assert.equal added for the packages/ui product e2e gate.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI wall-clock on recent main merges is ~3–3.5 minutes and is dominated by the longest parallel lane, not the sum of jobs. Measurement on #2580 / #2587 showed:
test_workspaces~177s often sets the critical path on large PRspackages/uiunit test editse2e×2 +alignment_audit) after the e2e suite was already slimChanges
scripts/ci-test-plan.mjs): unit/test paths underpackages/ui/srcand renderer no longer force Storybook or Electron e2e; product sources still do.e2ejob runs desktop e2e then alignment audit (sharednpm ci+ built renderer). Removed shard matrix and standalone alignment job.Test plan
node --test scripts/ci-test-plan.test.mjse2ejob when e2e selected (noe2e_shard/alignment_audit)__tests__-only commit does not start storybook or e2e