Uh oh!
There was an error while loading. Please reload this page.
fix: fail bare rate limits and show retry waits - #3115
Conversation
📝 WalkthroughProblem solvedBare DesignThe PR extends the existing live The added protocol validation, event handling, projection logic, and UI presentation form the smallest coherent solution for persistence, remount behavior, and user feedback. The added complexity is required to distinguish scheduled retries from completed content and to prevent stale retry state from returning. No safe deletion or simplification is evident from the current diff. The new tests cover protocol decoding, projection, continuity, error classification, telemetry, and UI-facing behavior. Validation and risksCoverage was added or updated for runtime, runtime-host, session projection, session continuity, protocol compatibility, retry classification, telemetry, and formatting. The runtime-host compatibility epoch increased from Repository-wide tests were not run. A live Electron remount was not verified. Required checks therefore remain unverified without direct check results. Review-relevant risks
WalkthroughThe PR makes rate-limit retries conditional on valid ChangesProvider retry flow
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk:🟡 Moderate · up to Remounting during a provider retry can show a countdown longer than the actual remaining wait because the scheduled retry time is not preserved. This is a concrete user-visible correctness issue that should be fixed before merge. Sequence Diagram(s)sequenceDiagram
participant Provider
participant Runtime
participant RuntimeHost
participant UI
Provider->>Runtime: return rate-limit error
Runtime->>Runtime: parse Retry-After
Runtime->>RuntimeHost: provide retry metadata
RuntimeHost->>RuntimeHost: publish provider_retry event
RuntimeHost->>UI: project retry snapshot
UI->>UI: render localized warning banner
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: af9b5f4d-87df-471c-86b7-6d7a4f3ac623
📒 Files selected for processing (21)
packages/core/src/agent-run.tspackages/runtime-host/src/__tests__/canonical-session-projection.test.tspackages/runtime-host/src/__tests__/protocol.test.tspackages/runtime-host/src/__tests__/session-projector.test.tspackages/runtime-host/src/adapter/session-projector.tspackages/runtime-host/src/protocol/operations.tspackages/runtime-host/src/protocol/turn.tspackages/runtime-host/src/server/canonical-turn-snapshot.tspackages/runtime/src/__tests__/model-adapter.test.tspackages/runtime/src/__tests__/provider-error-classification.test.tspackages/runtime/src/__tests__/provider-request-telemetry.test.tspackages/runtime/src/__tests__/session-manager.test.tspackages/runtime/src/agent-run.tspackages/runtime/src/provider-error-classification.tspackages/storage/src/agent-run-store.tspackages/ui/src/__tests__/provider-retry-presentation.test.tspackages/ui/src/chat-turn.tsxpackages/ui/src/conversation-copy.tspackages/ui/src/index.tspackages/ui/src/provider-retry-presentation.tspackages/ui/src/styles.css
Included review availability: Your plan includes up to 3 reviews per rolling hour; 1 remains after this review.
Uh oh!
There was an error while loading. Please reload this page.
968aae0 to
d2666f5CompareThere was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1c38e715-0bfe-4131-b811-131d2fbb9cd9
📒 Files selected for processing (10)
packages/runtime-host/src/__tests__/protocol.test.tspackages/runtime-host/src/__tests__/session-continuity-coordinator.test.tspackages/runtime-host/src/__tests__/session-projector.test.tspackages/runtime-host/src/adapter/session-projector.tspackages/runtime-host/src/protocol/index.tspackages/runtime-host/src/protocol/operations.tspackages/runtime-host/src/protocol/turn.tspackages/runtime-host/src/server/root-turn-coordinator.tspackages/runtime-host/src/server/session-continuity-coordinator.tspackages/ui/src/chat-turn.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
- packages/runtime-host/src/tests/protocol.test.ts
- packages/ui/src/chat-turn.tsx
- packages/runtime-host/src/protocol/turn.ts
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.
Uh oh!
There was an error while loading. Please reload this page.
d2666f5 to
3cc3de4CompareA bare 429, including OpenCode FreeUsageLimitError, is a quota or throttle without a recovery time. Retrying it ten times only hid the failure behind a three-minute empty wait. Keep automatic retries for rate limits that name Retry-After, and leave network or 5xx retries unchanged. Generated-by: Cursor Grok 4.5
The live retry line used the same muted working-status treatment as "thinking", so a 40-second rate-limit wait looked like a hang. Keep the existing live providerRetry object, and render its reason plus countdown through the shared Astryx Banner. Generated-by: Cursor Grok 4.5
A provider retry is still not a conversation fact. Hold the current wait on the in-memory Turn snapshot, publish it when it appears, and drop it on the next content event so remount cannot resurrect a finished wait. Generated-by: Cursor Grok 4.5
3cc3de4 to
f8eb564Compare
M4n5ter
left a comment
There was a problem hiding this comment.
LGTM. The rate-limit classification, transient retry overlay lifecycle, protocol boundary, and UI presentation are coherent and well covered by tests.
Summary
A bare 429, including OpenCode
FreeUsageLimitError, was retried ten times and looked like a hang. Rate limits now fail immediately unless the provider namesRetry-After. A real wait still is not a conversation fact: Host keeps the current overlay on the in-memory Turn snapshot, publishes it when it appears, and drops it on the next content event so remount cannot resurrect a finished wait. The chat shows that overlay as an Astryx warning Banner.Before — a muted status row with no reason:
After — an Astryx warning Banner with the retry reason:
Verification
packages/runtime/src/__tests__/provider-error-classification.test.ts(retries a rate limit only when the provider names a retry delay)packages/runtime/src/__tests__/session-manager.test.ts(provider retry progress reaches observers...)packages/runtime-host/src/__tests__/session-continuity-coordinator.test.ts(keeps the current provider retry on the live Turn until the next content event)packages/runtime-host/src/__tests__/session-projector.test.tspackages/runtime-host/src/__tests__/protocol.test.tspackages/runtime-host/src/__tests__/canonical-session-projection.test.tsnpm run format:checkDid not run repository-wide tests or a live Electron remount of a Retry-After wait.
AI use
Tool(s) and scope:
Cursor Grok 4.5 diagnosed the hung session, shaped the change, and authored the commits.
Checklist
Does this PR entail a change in behavior?