Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions apps/desktop/src/main/__tests__/ui-tsx-dead-export-contract.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
/**
* PR-UI-DEAD-EXPORT-SWEEP-0 — lock the rule "every named export in
* `packages/ui/src/ui.tsx` must have at least one consumer outside
* ui.tsx itself".
*
* Without this gate, `ui.tsx` slowly accumulates Base UI primitive
* re-exports + cva wrappers that nothing actually imports. They look
* cheap (`export const X = Base.Y`) but add real cost: every export
* shows up in autocomplete, in the bundle, in tsc work, and in design
* audits as "an option we offer". When ~30 of them are dead and ~50
* are alive, design discussions get poisoned by phantom variants.
*
* Allowlist:
* - `ui.tsx` itself (internal references are allowed)
* - `components.tsx` (legacy mega-module; gradually being unwound
* by PR-UI-LIB-EXTRACT-N; counts as a consumer for this gate)
*
* If a new export is introduced with no immediate consumer, the
* caller has two options:
* 1. Wire the consumer in the same PR (preferred)
* 2. Add the symbol to ALLOWED_PENDING below with a justification
* and a target removal date (so it doesn't linger forever)
*/

import { strict as assert } from 'node:assert';
import { readFile, readdir } from 'node:fs/promises';
import { resolve } from 'node:path';
import { describe, it } from 'node:test';

const REPO_ROOT = resolve(import.meta.dirname, '../../../../..');
const UI_FILE = resolve(REPO_ROOT, 'packages/ui/src/ui.tsx');
const SOURCE_ROOTS = [
resolve(REPO_ROOT, 'apps', 'desktop', 'src'),
resolve(REPO_ROOT, 'packages', 'ui', 'src'),
resolve(REPO_ROOT, 'packages', 'core', 'src'),
resolve(REPO_ROOT, 'packages', 'runtime', 'src'),
resolve(REPO_ROOT, 'packages', 'headless', 'src'),
resolve(REPO_ROOT, 'packages', 'storage', 'src'),
];
const SOURCE_EXTENSIONS = new Set(['.ts', '.tsx']);

/**
* Symbols that are exported but currently lack an external consumer.
* Empty by design: PR-UI-DEAD-EXPORT-SWEEP-0 cleared the slate. Any
* future entry needs a one-line justification + target removal date.
*/
const ALLOWED_PENDING: ReadonlyArray<{ name: string; reason: string }> = [
// intentionally empty
];

async function readSourceFiles(dir: string): Promise<{ path: string; content: string }[]> {
const entries = await readdir(dir, { withFileTypes: true });
const files = await Promise.all(
entries.map(async (entry) => {
const entryPath = resolve(dir, entry.name);
if (entry.isDirectory()) {
if (entry.name === '__tests__' || entry.name === 'node_modules' || entry.name === 'dist') return [];
return readSourceFiles(entryPath);
}
const ext = entryPath.slice(entryPath.lastIndexOf('.'));
if (!SOURCE_EXTENSIONS.has(ext)) return [];
const content = await readFile(entryPath, 'utf8');
return [{ path: entryPath, content }];
}),
);
return files.flat();
}

function extractNamedExports(src: string): string[] {
// Match: `export const Foo`, `export function Foo`, `export interface Foo`,
// `export type Foo`, `export class Foo`.
const names = new Set<string>();
for (const m of src.matchAll(/^export (?:const|function|interface|type|class) ([A-Za-z][A-Za-z0-9_]*)/gm)) {
names.add(m[1]!);
}
// Match: `export { Foo } from './path.js'` — only `cn` re-export today,
// but include for completeness.
for (const m of src.matchAll(/^export \{ ([^}]+) \}/gm)) {
for (const part of m[1]!.split(',')) {
const name = part.trim().split(/\s+as\s+/)[0]?.trim();
if (name && /^[A-Za-z]/.test(name)) names.add(name);
}
}
return [...names];
}

describe('PR-UI-DEAD-EXPORT-SWEEP-0 ui.tsx dead-export contract', () => {
it('every named export in ui.tsx has at least one consumer outside ui.tsx', async () => {
const [uiSrc, allSources] = await Promise.all([
readFile(UI_FILE, 'utf8'),
Promise.all(SOURCE_ROOTS.map((root) => readSourceFiles(root))).then((groups) => groups.flat()),
]);
const exports = extractNamedExports(uiSrc);
assert.ok(exports.length > 0, 'ui.tsx must continue to export symbols (sanity check)');

const pending = new Set(ALLOWED_PENDING.map((entry) => entry.name));
const dead: string[] = [];
for (const name of exports) {
if (pending.has(name)) continue;
const re = new RegExp(`\\b${name}\\b`);
const hasConsumer = allSources.some((file) => {
if (file.path === UI_FILE) return false;
return re.test(file.content);
});
if (!hasConsumer) dead.push(name);
}

assert.deepEqual(
dead,
[],
`ui.tsx exports without any consumer outside ui.tsx (delete the export, wire a consumer, or add to ALLOWED_PENDING with a target removal date): ${dead.join(', ')}`,
);
});

it('ALLOWED_PENDING does not accumulate stale entries', () => {
// The expectation here is that ALLOWED_PENDING stays empty by
// default. If it grows past a small handful, that's a signal the
// codebase has started reintroducing dead exports — at which point
// the cap forces a cleanup PR rather than letting the list rot.
assert.ok(
ALLOWED_PENDING.length <= 5,
`ALLOWED_PENDING has ${ALLOWED_PENDING.length} entries (cap 5). Either ship the consumers or delete the exports.`,
);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,20 +45,14 @@ const ALLOWED_BARE: ReadonlyArray<{ pattern: string; count: number; reason: stri
pattern: 'z-50',
count: 2,
reason:
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26).',
'dialog popup (DialogContent) + sheet popup. The previously z-50 floating-overlay surfaces (TooltipPopup, SelectPopup, PopoverPopup) were tokenized to `z-[var(--z-overlay)]` so a Select opened from inside a Settings modal floats above the modal (WAWQAQ msg `d3ea9a33` 2026-06-26). PR-UI-DEAD-EXPORT-SWEEP-0 then deleted PopoverPopup entirely (was unused).',
},
{
pattern: 'backdrop-blur-sm',
count: 2,
reason:
'dialog + sheet backdrop visual depth. Pending kenji #6 audit decision on whether to drop blur entirely or tokenize a single --blur-scrim value.',
},
{
pattern: 'transition-[height]',
count: 1,
reason:
'accordion content panel needs height animation because content is variable-height; `transform: scaleY` would distort children. Layout-property transition is intentional here.',
},
];

describe('PR-FE-BUG-HUNT-12 ui.tsx design contract', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/src/components.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,6 @@ import {
import {
Badge,
Button as UiButton,
Card,
Checkbox,
DialogClose,
DialogContent,
Expand Down
Loading