Uh oh!
There was an error while loading. Please reload this page.
feat(core): enrich model catalog metadata - #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enrich core model catalog metadata with static limits and lightweight capabilities for curated models, then use provider/access-path-specific facts only when provider discovery did not return them.
Why
Future context-budget and compaction decisions need per-model context window and max output token facts. Today the catalog can carry those fields, but many provider model-list responses do not include them, leaving known models with
undefinedlimits.Scope
Changed:
contextWindow,maxOutputTokens, and capability metadata to the curated model metadata table.models.dev/api.jsonwhere available.Not included:
codex-subscriptioninternal identifier.claude-subscriptioninternal identifier.ContextBudgetPolicyor automatic compaction behavior changes.ModelCatalogEntryshape change or per-field provenance object.Verification
npm run -w @maka/core testnpm run -w @maka/ui testnpm run -w @maka/desktop test -- --test-name-pattern "visible copy|OpenAI OAuth account path"npm run typecheckgit diff --checkUser-facing impact
Known model catalog entries now carry richer metadata that future budget/compaction work can consume. The ChatGPT/Codex OAuth account path is now labeled OpenAI OAuth in visible provider/model picker surfaces. When live model discovery is unavailable, catalog entries can use curated fallback choices so current known models still appear in the picker.
Reviewer notes
Review fixes included: OpenAI OAuth no longer reuses OpenAI API GPT-5.5 limits, Claude subscription no longer reuses Anthropic API limits or capabilities, partial provider capabilities now merge per field while preserving explicit
false, availability uses those merged capabilities, Anthropic API Sonnet 4.6 uses the provider-specific 128K max output limit, and curated catalog fallbacks are named and tested as an intentional no-live-model picker behavior. Internal subscription identifiers are intentionally left unchanged in this PR to avoid unrelated migrations.