Skip to content

feat(desktop): add conservative WorkHub session router#3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 6 commits into from
Aug 23, 2026
Merged

feat(desktop): add conservative WorkHub session router #3497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13f65d2
fix(desktop): harden WorkHub review paths
ARE404 Aug 22, 2026
68f6b7c
chore: add ASF headers to WorkHub sources
ARE404 Aug 22, 2026
4a67b3e
fix: harden WorkHub routing corrections
ARE404 Aug 23, 2026
6304748
fix: distinguish one-character Session names
ARE404 Aug 23, 2026
5e8ac55
fix(desktop): preserve granular queue operations after rebase
ARE404 Aug 23, 2026
bcc1fff
chore(cli): add ASF headers to session status files
ARE404 Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions apps/desktop/src/main/__tests__/permission-response-ipc-boundary.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -247,10 +247,19 @@ describe('permission response IPC boundary', () => {

it('accepts only the supported stop source', () => {
assert.deepEqual(normalizeStopSessionInput(undefined), {});
assert.deepEqual(normalizeStopSessionInput({ source: 'stop_button', extra: true }), {
source: 'stop_button',
});
assert.deepEqual(
normalizeStopSessionInput({
source: 'stop_button',
expectedTurnId: 'turn-workhub',
extra: true,
}),
{ source: 'stop_button', expectedTurnId: 'turn-workhub' },
);
assert.throws(() => normalizeStopSessionInput(null), /stop session input/);
assert.throws(() => normalizeStopSessionInput({ source: 'toolbar' }), /stop session source/);
assert.throws(
() => normalizeStopSessionInput({ expectedTurnId: '' }),
/expectedTurnId/,
);
});
});
10 changes: 9 additions & 1 deletion apps/desktop/src/main/__tests__/runtime-host-session-execution-ipc-main.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -883,7 +883,15 @@ test("binds steer and stop to Host-owned queue and active Turn identities", asyn
kind: "queued",
},
);
await ipc.invoke("sessions:stop", "session-1");
await ipc.invoke("sessions:stop", "session-1", {
source: "stop_button",
expectedTurnId: "turn-unrelated",
});
assert.deepEqual(stopLifecycle, []);
await ipc.invoke("sessions:stop", "session-1", {
source: "stop_button",
expectedTurnId: "turn-1",
});
assert.deepEqual(stopLifecycle, ["teardown", "interrupt"]);

assert.deepEqual(submits, [
Expand Down
Loading