Uh oh!
There was an error while loading. Please reload this page.
ci: enforce Astryx inventory for code changes - #3647
Merged
Astro-Han merged 1 commit intoAug 23, 2026
Conversation
Refresh the stale surface count and run the repository-wide inventory gate before Build whenever code validation is selected. Fixesapache#3646 Generated-by: OpenAI Codex
liuxiaocs7
commented
Aug 23, 2026
MemberAuthor
Hi, @Astro-Han, could you help take a look when free, thanks! |
Astro-Han
approved these changes
Aug 23, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at exact head f046172ab9661d648116394c6887ae4368eb0bd9. No P0–P3 findings. The gate remains scoped by the existing planner: ordinary documentation-only changes keep code=false and do not run it, inventory artifacts run through astryx_surface, and code changes run the repository-wide regenerate-and-diff check before Build. The committed 206-file inventory regenerates byte-for-byte; planner tests pass 30/30, and the exact-head test check is terminal green.
Uh oh!
There was an error while loading. Please reload this page.
mikemikimike pushed a commit
to mikemikimike/maka
that referenced
this pull request
Aug 23, 2026
Refresh the stale surface count and run the repository-wide inventory gate before Build whenever code validation is selected. Fixesapache#3646 Generated-by: OpenAI Codex
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While validating the Desktop build fix in #3643, we found that the generated Astryx surface inventory still reported 204 files even though the current path list and table contain 206. Because the gate was selected only for direct Astryx-surface changes, repository-wide drift could escape ordinary code validation.
Fixes#3646
Verification
Passed locally:
node --test scripts/ci-test-plan.test.mjs(30/30)npm run astryx:surface-inventory(206 files)npm run lintnpm run format:checknpm run buildnpm run typecheckgit diff --checkAlso attempted
NODE_NO_WARNINGS=1 npm test. The suites covering this change passed, while the repository-wide run remained non-green on three unrelated checks: an existing UI deferred-activation assertion, a Runtime Host real-model terminal timeout, and a Python test that uses Python 3.10 union syntax on the local Python 3.9.6 runtime.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex helped diagnose the CI coverage gap, implement the workflow and regression-test changes, and draft the issue and PR text.
Checklist
Does this PR entail a change in behavior?