') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(runtime): add the missing ASF headers to the plugin modules by Astro-Han · Pull Request #3708 · apache/maka · GitHub
Skip to content

fix(runtime): add the missing ASF headers to the plugin modules - #3708

Merged
Astro-Han merged 1 commit into
mainfrom
fix/asf-headers-plugin-runtime
Aug 24, 2026
Merged

fix(runtime): add the missing ASF headers to the plugin modules#3708
Astro-Han merged 1 commit into
mainfrom
fix/asf-headers-plugin-runtime

Conversation

@Astro-Han

@Astro-HanAstro-Han commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Check ASF source headers is failing on main, so main and every branch built on it currently report a red CI run for a reason unrelated to their own changes.

Five files added by #3250 carry no license header:

packages/runtime/src/plugin-kernel.ts
packages/runtime/src/plugin-runtime.ts
packages/runtime/src/plugin-composition-loader.ts
packages/runtime/src/__tests__/plugin-kernel.test.ts
packages/runtime/src/__tests__/plugin-composition-loader.test.ts

#3250's own commit was already red for this, so the failure arrived with that merge rather than with anything after it.

This change is the output of node scripts/asf-license-headers.mjs write and nothing else — the standard header the script emits, added to those five files, +95 lines and no logic change. After it, node scripts/asf-license-headers.mjs check reports all 2819 covered files clean, which I verified on a clean checkout of current main.

@likun666661 — you own #3250, so if you would rather land this yourself, please say so and I will close this. I opened it because main being red makes every other PR's CI harder to read, and this seemed worth unblocking quickly rather than waiting.

简体中文

main 上的 Check ASF source headers 正在失败，因此 main 以及所有基于它的分支，当前都会因为与自身改动无关的原因报出一次红色 CI。

#3250 新增的五个文件没有版权头：

packages/runtime/src/plugin-kernel.ts
packages/runtime/src/plugin-runtime.ts
packages/runtime/src/plugin-composition-loader.ts
packages/runtime/src/__tests__/plugin-kernel.test.ts
packages/runtime/src/__tests__/plugin-composition-loader.test.ts

#3250 自己那个提交上的 CI 就已经是红的，所以这个失败是随那次合并到来的，不是之后的改动引入的。

本次改动就是 node scripts/asf-license-headers.mjs write 的输出，除此之外没有别的内容——把脚本生成的标准版权头加到这五个文件上，+95 行，零逻辑改动。之后 node scripts/asf-license-headers.mjs check 报告 2819 个受覆盖文件全部通过，我在当前 main 的干净检出上验证过。

@likun666661 —— #3250 是你的，如果你更希望自己来修，说一声我就把这个关掉。我开这个 PR 是因为 main 红着会让其他所有 PR 的 CI 结果难以判读，觉得值得尽快解开，而不是等。

@Astro-Han
fix(runtime): add the missing ASF headers to the plugin modules
b0a20d1
`Check ASF source headers` fails on main. Five files added by #3250 carry
no license header, so `main` and every branch built on it report a red CI
run for a reason unrelated to their own changes.
Generated by `node scripts/asf-license-headers.mjs write`; the header text
is the standard one the script emits, and nothing else in these files
changed.
@Astro-HanAstro-Han mentioned this pull request Aug 24, 2026
Merged
6 tasks
zhiiw
zhiiw approved these changes Aug 24, 2026
View reviewed changes

@zhiiwzhiiw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at exact head b0a20d19c77b71128dc619a5ca6d1624cb759e2d: the diff is header-only (every added line is the ASF header comment, zero logic lines). I regenerated the headers independently on clean origin/main with node scripts/asf-license-headers.mjs write — the result is byte-identical to this PR's diff across all five files, and check then reports 2819 covered files all passing. test is completed/success on the exact head.

@UncertaintyDeterminesYou4ndMeUncertaintyDeterminesYou4ndMe mentioned this pull request Aug 24, 2026
Merged
6 tasks
M4n5ter
M4n5ter approved these changes Aug 24, 2026
View reviewed changes

@M4n5terM4n5ter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at exact head b0a20d1. Each of the five files adds the same standard 19-line ASF license header, and the remaining file contents are byte-identical to the base revision. The exact-head CI check is terminal and successful.

@Astro-Han

Astro-Han commented Aug 24, 2026

Copy link
Copy Markdown
ContributorAuthor

LGTM. The diff adds only the standard 19-line ASF license header to five files; with those lines removed the bodies are byte-identical to the base. test is green on the current head. Merging to unblock main.

简体中文

已确认。这个 diff 只是给五个文件加上标准的 19 行 ASF license header，去掉这些行后正文与 base 逐字节一致。当前 head 上 test 已通过。合并以恢复 main。

@Astro-Han
Astro-Han merged commit 3898026 into mainAug 24, 2026
1 check passed
@Astro-Han
Astro-Han deleted the fix/asf-headers-plugin-runtime branch August 24, 2026 11:47
@chihumyumchihumyum mentioned this pull request Aug 24, 2026
Merged
6 tasks
@Astro-HanAstro-Han mentioned this pull request Aug 24, 2026
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiiwzhiiwzhiiw approved these changes
@M4n5terM4n5terM4n5ter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Astro-Han@zhiiw@M4n5ter