Uh oh!
There was an error while loading. Please reload this page.
chore(deps): bump Astryx core to 0.5.0 - #3755
Conversation
Astro-Han
commented
Aug 25, 2026
Hi, Could you include the tools used in the commit? |
Astro-Han
commented
Aug 25, 2026
Also CI need fixing. |
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
The bump to Astryx 0.5.0 correctly converges the two upstream-absorbed hunks and regenerates the remaining 5 hunks against the new dist, with THIRD_PARTY_NOTICES in sync. No new business logic.
Minor note: patch still carries 5 hunks (+36/-71 net reduction) — a maintained holding cost to be re-checked on next upstream bump (already documented).
No P0-P2.
简体中文
该头未发现阻断,剩余补丁持有成本可接受。1174414 to
26b5365Compare
Astro-Han
left a comment
There was a problem hiding this comment.
I verified this rebased head.
The only change vs 11744146 is a LICENSE line updating the patch filename to 0.5.0.patch, matching the prior patch rename. No runtime changes beyond the previously reviewed Astryx 0.5.0 convergence. Previous P3 holding-cost note remains.
No P0-P2.
简体中文
该头为 LICENSE 同步重整,无新增阻断。Astro-Han
commented
Aug 25, 2026
Got a CI error need fixing: |
Astro-Han
left a comment
There was a problem hiding this comment.
Update on cd90e76d07:
Only astryx-theme/maka.{css,js} refreshed vs 26b5365. No runtime changes beyond prior Astryx convergence.
No P0-P2.
简体中文
该头为主题产物刷新,无新增阻断。
Astro-Han
left a comment
There was a problem hiding this comment.
Update on 30d55520b4:
Only aria-current="page" → "true" test sync vs cd90e76d. No runtime changes beyond prior Astryx convergence.
No P0-P2.
简体中文
该头为测试断言同步,无新增阻断。testikun
commented
Aug 25, 2026
Follow-up fix pushed in Astryx 0.5.0 no longer exposed the nested Local verification: Storybook build plus all 194 Storybook smoke stories pass; repository typecheck, format check, and lint pass. The Windows release check also passes on the new head. 简体中文为远程项目目录对话框增加显式 aria-label,修复 Astryx 0.5.0 下 Storybook 无障碍审计找不到 Build Host 对话框名称的问题。Generated-by: OpenAI Codex |
testikun
commented
Aug 26, 2026
Follow-up fix pushed in The failing Storybook story used a fixed 100ms wait after the optimistic checkbox flip. Under CI load, the persisted setting/readback can settle after that deadline even though the implementation is correct, producing a false failure. The story now polls for the confirmed persisted Local verification: Storybook build plus all 194 smoke stories pass; typecheck, format check, and lint pass. 简体中文该失败是 Storybook 故事固定等待 100ms 导致的竞态,不是业务逻辑失败。现在改为有界轮询持久化状态,兼容 CI 负载和菜单异步关闭。Generated-by: OpenAI Codex |
There was a problem hiding this comment.
One P1 inline on LICENSE; that is the only thing I would hold the merge for.
The rest of the bump verified clean: the aria-currentpage → true test updates track a deliberate upstream a11y correction in dist/TabList/Tab.js (and SideNavItem still emits page, so sidebar.css's selectors are correctly untouched), the aria-label fix is genuinely local because RemoteProjectDirectoryDialog is the only one of fourteen Dialog call sites that renders its DialogHeader conditionally, dropping the Kbd.js and useHotkeys.js patch hunks is safe because 0.5.0 carries both blank-UA-CH fixes verbatim, and the story change from a fixed 100ms wait to polling is a legitimate flake fix.
AI use: drafted with Claude Code (Opus 5); I verified every claim in it against the 0.4.5 and 0.5.0 package sources and the repo at bdffa4f3c before posting.
| @@ -236,7 +236,7 @@ License: MIT | |||
| Maka includes an ejected adaptation of Astryx ChatReasoning v0.1.9 and generated | |||
| theme artifacts based on Astryx theme-neutral v0.4.5. Maka also redistributes | |||
There was a problem hiding this comment.
P1 — LICENSE now misattributes the regenerated theme artifacts.
This PR bumps @astryxdesign/theme-neutral to 0.5.0 and regenerates maka.css and maka.js — the output really did change (#e33f4a → #c9303a for the error color, three places in each file). This line still says the redistributed artifacts are "generated theme artifacts based on Astryx theme-neutral v0.4.5", so after merge LICENSE attributes shipped generated material to a version it was not generated from. The line below was updated to @astryxdesign+core+0.5.0.patch, so the paragraph was edited and the version in this sentence was simply missed.
Please also check Theme revision: 110987b4505dc44119b94bed53d92b9840088a61 on line 233. If that pins the upstream commit the theme was generated from, it is stale for the same reason — I cannot tell which release that sha belongs to.
Worth noting why this is easy to miss rather than treating it as carelessness: this paragraph hand-carries three separate version facts — the core patch filename, the theme-neutral version, and the theme revision sha — whose real authorities live in package.json, the patches/ filename, and the upstream repository. Nothing binds the prose to any of them, and neither check:third-party-notices nor check:stale reads it, which is why CI is green here. The 0.4.0 → 0.4.5 bump updated this paragraph; this one updated a third of it. As long as the copy is synced by hand it will keep drifting.
Blocking only because LICENSE ships in the release and an incubating release vote reads it.
Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
There was a problem hiding this comment.
Fixed in 03774d58b, rebased onto the latest apache/main (2b4c0deaa).
- Updated the LICENSE attribution from
theme-neutral v0.4.5tov0.5.0. - Updated
Theme revisiontoea888ef33283ea44e37817d36bc8e84a0568bc30, the commit behind Astryx tagv0.5.0.
The change is limited to these two LICENSE lines; all generated artifacts and runtime code are unchanged. The focused legal inventory test passes, and the repository ASF-source check is blocked locally only by the available Node runtime lacking stripTypeScriptTypes; CI remains authoritative.
简体中文:已修复 LICENSE 中过期的主题版本和 revision SHA,并基于最新主干重放后推送。
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Record the Astryx theme-neutral 0.5.0 source and its v0.5.0 revision in the distributed license attribution. Generated-by: OpenAI Codex
bdffa4f to
03774d5Compare
Astro-Han
left a comment
There was a problem hiding this comment.
I reviewed this head and found no blocking issues.
Bumps Astryx core 0.5.0 with regenerated theme artifacts and aligned a11y/story fixes; hosted test/audit/package/owner all SUCCESS.
No P0-P3.
简体中文
该头无阻断。Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
Astro-Han
left a comment
There was a problem hiding this comment.
Verified the fix in 03774d58b. Both facts are now correct, and the revision line was worse than I flagged: I resolved both shas against facebook/astryx, and the old 110987b4505d is chore: version packages for v0.4.0 — it was already pointing a release behind the prose that claimed v0.4.5. The new ea888ef33283 is release: v0.5.0 (#5435), so this is the first time the revision and the version in this paragraph actually agree. All five checks are green.
AI use: reviewed with Claude Code (Opus 5); I verified the diff, both upstream commits, and CI state myself before approving.
Uh oh!
There was an error while loading. Please reload this page.
Summary
@astryxdesign/corefrom 0.4.5 to 0.5.0 across the root, UI, and Desktop packages.@astryxdesign/theme-neutralto 0.5.0 so its strict peer dependency matches the new core version.patch-packagepatch as@astryxdesign/core@0.5.0.Kbd.jsanduseHotkeys.js).Fixes#3753
Verification
npm ciapplies the 0.5.0 patch successfully.@maka/uitests: 227 passed.npm run format:checkpassed.npm run lintpassed.npm run check:third-party-noticespassed.npm run check:stalepassed.Manual CJK IME interaction was not run in the automated environment; the affected UI package and Desktop suites pass.
简体中文摘要
本 PR 将
@astryxdesign/core从 0.4.5 升级到 0.5.0,并同步升级具有严格 peer 依赖的theme-neutral。重新生成了 0.5.0 版本 patch,删除已经被上游吸收的Kbd.js和useHotkeys.js两个 hunk,同时更新 lockfile、许可证清单和 patch 文档。干净安装、UI 测试、Desktop 类型检查、Desktop 主进程测试、构建、lint、format 和 stale/许可证检查均已通过。
AI use
Tool(s) and scope: OpenAI Codex assisted with the dependency-upgrade analysis, patch regeneration, affected-file updates, regression verification, and PR preparation. The commit includes the
Generated-by: OpenAI Codextrailer; the human contributor remains responsible for review and submission.