Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(desktop): hide collapsed sidebar icon rail by ButterBright · Pull Request #3808 · apache/maka · GitHub
Skip to content

fix(desktop): hide collapsed sidebar icon rail - #3808

Merged
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main
Aug 27, 2026
Merged

fix(desktop): hide collapsed sidebar icon rail#3808
Astro-Han merged 2 commits into
apache:mainfrom
ButterBright:main

Conversation

@ButterBright

@ButterBrightButterBright commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the macOS traffic-light buttons so they no longer span the sidebar and main content area.

Collapsed macOS titlebar

When collapsed, the sidebar now:

  • Closes completely instead of leaving a 48px icon rail.
  • Removes hidden sidebar controls from pointer and keyboard interaction.
  • Keeps the titlebar restore action visible so the sidebar can be reopened.

Verification

Added Playwright coverage confirming that:

  • The collapsed sidebar has a width of 0px.
  • Sidebar navigation is hidden while collapsed.
  • The titlebar restore action remains visible.
  • The sidebar can be expanded again.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Investigated the collapsed-sidebar layout, implemented the CSS and Storybook updates, added targeted Playwright coverage.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on 1ffbc27c87:

Standards NO-GO (5 hard): missing real-window smoke (smoke:real-window), incomplete before/after evidence, missing AI-use declaration, incomplete PR template/branch naming. Code itself is Spec PASS — collapsed rail correctly hidden via visibility:hidden with restore action. CI test is still QUEUED — not green.

简体中文因流程与验证材料缺失暂不通过。

@ButterBright

Copy link
Copy Markdown
MemberAuthor

Updated.

@Astro-Han

Copy link
Copy Markdown
Contributor

Thanks, nice fix~ The e2e might need some fix since it changes the folding action. Can we take a look at the e2e test and fix these?

@github-actionsgithub-actionsBot added the effort/S Under 100 readable lines label Aug 27, 2026

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded — see the approving review for the final findings. (Trimmed: this pass raised a P1 about collapsed-state navigation that I later withdrew as incorrect.)

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: the P1 I raised about collapsed-state navigation was wrong, and I withdrew it.

command-palette.tsx:59-65 registers mod+k at window level, and command-palette-commands.ts:252-284 routes to skills, mcp, scheduled-tasks and daily-review. So collapsed, 扩展 and 自动化 are reachable via ⌘K, 新任务 via ⌘N, 设置 via ⌘,. Only the WorkHub rail item and the update reminder lose an entry point, and WorkHub is off by default with a return path in the session view.

My mistake was checking the menu and titlebar and stopping there instead of enumerating setNavSelection callers.

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. CSS mechanism and titlebar grid arithmetic verified; the earlier P1 is withdrawn (see the correction above).

P3s, non-blocking:

  1. ensureSidebarExpanded (fixtures.ts:62-72) uses isVisible(), which does not auto-wait — six call sites inherit it, and it will produce flakes that look unrelated. Fix this one first. It also hard-codes strings that live in shell-copy.ts.
  2. Four collapsed-state rules in sidebar.css (:130-132, :186-190, :209-211, :239-241) now style an invisible subtree; their comments still describe the 48px rail, as does session-sidebar-nav.tsx:191. Delete with the rail.
  3. app-shell-chrome-actions.tsx:116-118 refers to a rail that no longer exists.
  4. pointer-events: none is redundant with visibility: hidden.
  5. visibility is not transitioned, so content vanishes on frame one while the wrapper eases 260px → 0.

Also worth stating in the body: the collapsed rail's six entries are gone and ⌘K/⌘N/⌘, carry them now.

AI use: Claude Code (Opus) assisted; I verified the CSS mechanism, grid arithmetic, and collapsed-state reachability myself. Nothing was rendered — the traffic-light claim rests on the author's screenshot.

@Astro-Han
Astro-Han merged commit 97f6b4b into apache:mainAug 27, 2026
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/SUnder 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ButterBright@Astro-Han