Skip to content

fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Aug 30, 2026
Merged

fix(build): derive Astryx surface inventory from @astryxdesign/core #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
fi

- name: Install dependencies
if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
run: npm ci

# The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
# directly instead of being hidden behind an earlier compilation failure.
- name: Astryx surface inventory
if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
run: npm run astryx:surface-inventory
run: |
npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.
npm run astryx:surface-inventory:test

- name: Build
if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down
5 changes: 4 additions & 1 deletion docs/astryx-alignment-inventory.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down
180 changes: 91 additions & 89 deletions docs/astryx-surface-file-inventory.md
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
"astryx:theme": "node scripts/build-astryx-theme.mjs",
"astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
"astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
"astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
"sync:model-metadata": "node scripts/sync-model-metadata.mjs",
"refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
"check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down
14 changes: 14 additions & 0 deletions scripts/ci-test-plan.test.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
const workflow = readWorkflow('ci.yml');
// The inventory step imports the generator, which resolves @astryxdesign/core
// and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
// without `code`, so the `npm ci` step must gate on astryx_surface too — else
// the generator runs with no dependencies installed and fails closed.
const npmCi = workflow.indexOf('run: npm ci');
assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
const stepEnd = workflow.indexOf('\n - ', npmCi);
const installStep = workflow.slice(stepStart, stepEnd);
assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
const workflow = readWorkflow('ci.yml');
const toolchain = workflow.indexOf(
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(build): derive Astryx surface inventory from @astryxdesign/core by liuxiaocs7 · Pull Request #3883 · apache/maka · GitHub
Skip to content
fix(build): derive Astryx surface inventory from @astryxdesign/core#3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Astro-Han
merged 1 commit into

from

Aug 30, 2026
 Merged


fix(build): derive Astryx surface inventory from @astryxdesign/core
#3883
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 4 additions & 2 deletions
.github/workflows/ci.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -143,7 +143,7 @@ jobs:
 fi

 - name: Install dependencies
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true' || steps.plan.outputs.asf_source == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
 run: npm ci

 # The header audit above remains install-free. The complete source gate
Expand DownExpand Up@@ -181,7 +181,9 @@ jobs:
 # directly instead of being hidden behind an earlier compilation failure.
 - name: Astryx surface inventory
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.astryx_surface == 'true'
 run: npm run astryx:surface-inventory
 run: |
 npm run astryx:surface-inventory
Comment thread
liuxiaocs7 marked this conversation as resolved.

 npm run astryx:surface-inventory:test

 - name: Build
 if: steps.plan.outputs.code == 'true' || steps.plan.outputs.cli_package == 'true' || steps.plan.outputs.release_contract == 'true'
Expand Down

5 changes: 4 additions & 1 deletion
docs/astryx-alignment-inventory.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,9 @@

Maps [Astryx wiki](https://github.com/facebook/astryx/wiki) conventions onto
Maka product surfaces. Severity: **blocker** (raw control when an Astryx twin
exists / broken hierarchy) · **polish** (off-scale px, density).
exists / broken hierarchy) · **reimplementation** (a public `@maka/ui` export
shadows a shipped Astryx component — a review signal, not proof) · **polish**
(off-scale px, density).

## Wiki smell checklist (searchable)

Expand All@@ -34,6 +36,7 @@ exists / broken hierarchy) · **polish** (off-scale px, density).
| Design · radius | Nested radii not `outer − gap` | Role radii |
| Design · elevation | Raw `box-shadow` / magic z-index | Elevation tokens |
| API · Use the System | Raw `<button>` / `<input>` / `<select>` with Astryx twin | `Button`, `TextInput`, `Selector`, `List`/`Item`, `EmptyState`, `Dialog`, `ToggleButton`, `Collapsible`, `SegmentedControl` |
| API · Use the System | Public `@maka/ui` export whose name shadows a shipped Astryx component (defined locally, not a re-export) | Re-export the Astryx component, or confirm the local one is intentional |
| Theming | One-off hex for ladder roles | Bridge + product tokens |
| Container padding | Product padding fighting `--container-padding-*` | Let Card/Section/Layout own inset |

Expand Down

180 changes: 91 additions & 89 deletions
docs/astryx-surface-file-inventory.md

View file


Open in desktop


Large diffs are not rendered by default.


1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,7 @@
 "astryx:theme": "node scripts/build-astryx-theme.mjs",
 "astryx:surface-inventory": "node scripts/check-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:write": "node scripts/generate-astryx-surface-inventory.mjs",
 "astryx:surface-inventory:test": "node --test scripts/generate-astryx-surface-inventory.test.mjs",
 "sync:model-metadata": "node scripts/sync-model-metadata.mjs",
 "refresh:model-metadata": "node scripts/sync-model-metadata.mjs --refresh",
 "check:model-metadata": "node scripts/sync-model-metadata.mjs --check",
Expand Down

14 changes: 14 additions & 0 deletions
scripts/ci-test-plan.test.mjs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -325,6 +325,20 @@ test('core CI checks the Astryx inventory for every code change before building'
 assert.doesNotMatch(inventoryStep, /continue-on-error/u);
});

test('CI installs dependencies whenever the Astryx surface inventory runs', () => {
 const workflow = readWorkflow('ci.yml');
 // The inventory step imports the generator, which resolves @astryxdesign/core
 // and parses the @maka/ui barrel. An inventory-doc-only PR is `astryx_surface`
 // without `code`, so the `npm ci` step must gate on astryx_surface too — else
 // the generator runs with no dependencies installed and fails closed.
 const npmCi = workflow.indexOf('run: npm ci');
 assert.ok(npmCi >= 0, 'expected an `npm ci` install step');
 const stepStart = workflow.lastIndexOf('\n - name:', npmCi) + 1;
 const stepEnd = workflow.indexOf('\n - ', npmCi);
 const installStep = workflow.slice(stepStart, stepEnd);
 assert.match(installStep, /steps\.plan\.outputs\.astryx_surface == 'true'/u);
});

test('core CI validates affected installed CLI packages on its existing runner', () => {
 const workflow = readWorkflow('ci.yml');
 const toolchain = workflow.indexOf(
Expand Down
Loading