Uh oh!
There was an error while loading. Please reload this page.
fix(runtime): preserve Plan final responses - #3886
Conversation
14d2fc0 to
13157afCompareTreat completed and cancelled Plan executions as tool boundaries so the model can consume the durable result and produce its final response. Keep SubmitPlan as the explicit approval handoff. Generated-by: Maka
13157af to
080ef8cCompare
Astro-Han
left a comment
There was a problem hiding this comment.
Thanks for the focused fix. The Plan result was already durable, but plan_execution_completed and cancelled still stopped the provider loop before it could produce the final response. Removing that stop behavior at the existing Plan tool boundary addresses the root cause without moving PlanStore authority or adding another state.
The SubmitPlan handoff behavior remains unchanged, and the regression coverage plus exact-head CI support the intended continuation behavior.
Reviewed with Codex and an independent @Reviewer agent. I verified the problem path, Plan/Turn ownership boundary, focused diff, and passing CI.
中文对照
谢谢你做了这个聚焦的修复。Plan 结果已经持久化,但 plan_execution_completed 和 cancelled 仍会提前停止 provider loop,导致最终回复无法生成。在既有 Plan tool 边界移除这两个 stop 行为,直接解决了根因,也没有移动 PlanStore 的 authority 或增加新状态。
SubmitPlan 的 handoff 行为保持不变,回归测试和精确 head 的 CI 也支持预期的 continuation 行为。
本次审查使用了 Codex 和一个独立的 @Reviewer 子代理;我核对了问题路径、Plan/Turn 职责边界、聚焦 diff 和 CI 结果。
Uh oh!
There was an error while loading. Please reload this page.
Plan execution completion is a tool boundary, not a conversational terminal. Stop setting the agent-loop stop flag for completed and cancelled Plan executions so the model can consume the durable result and produce a final response.
Keep
SubmitPlanas the explicit one-stepplan_handoff, and cover completion, cancellation, and submission boundaries with provider-loop regressions.Fixes#3884
Verification
npm --workspace @maka/runtime run typechecknpm --workspace @maka/runtime run buildnode --test packages/runtime/dist/__tests__/ai-sdk-backend.test.js— 202/202 passednpx biome check packages/runtime/src/ai-sdk-backend.ts packages/runtime/src/__tests__/ai-sdk-backend.test.tsgit diff --checkAI use
Select exactly one:
Tool(s) and scope: Maka investigated the Runtime Plan terminal path, implemented the loop-boundary change, and authored the regression coverage and PR text. The commit includes a
Generated-by: Makatrailer.Checklist
Does this PR entail a change in behavior?