Uh oh!
There was an error while loading. Please reload this page.
fix(tui): preserve legacy editor undo - #3929
Conversation
Generated-by: Codex
jackwener
left a comment
There was a problem hiding this comment.
I reviewed exact head b9efb36aec2383f5b83faa799968b0da341202ed and found no blocking issues.
The raw 0x1f ambiguity is now consumed only while a side-conversation pair exists. Before that, the byte reaches the editor's legacy undo binding; after a pair exists, both the legacy byte and enhanced Ctrl+/ sequence retain side switching. The new regression exercises the real TUI input path and confirms that undo clears the draft without switching Sessions.
The exact-head test and windows_recovery checks succeeded. A synthetic merge with current main (a6866d05918bd4c2ea25ccd682edc6033726f782) is clean. No P0-P3 findings.
Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.
简体中文
本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查,也不能替代人类审查。有人类对本条评论负责,如有错误请直接指出。
Summary
Preserve the editor's legacy
Ctrl+-undo path until a side conversation exists.The TUI now reserves the ambiguous
0x1fbyte for side switching only while a side pair is active. Enhanced keyboard-protocol shortcuts and active side switching keep their existing behavior.Fixes#3928
Verification
origin/mainand passes with this fixnpm run lintnpm run format:checknpm run buildnpm run typechecknpm --workspace maka-agent run test:dist— 514 passednpm run check:asf-headersnpx knip --workspace apps/desktopnpx knip --workspace packages/uigit diff --checkAdditional check:
npx knip --workspace packages/clireports five unused exported types that are already present onorigin/main; this PR adds none of them.AI use
Select exactly one:
Tool(s) and scope: Codex reproduced the legacy key collision, implemented the state-scoped interception, added the regression, and performed first-principles, adversarial, and simplification reviews.
Checklist
Does this PR entail a change in behavior?