Uh oh!
There was an error while loading. Please reload this page.
fix(eval): make process termination work on Windows - #4175
Open
jjj-n wants to merge 1 commit into
Open
Conversation
Use native graceful termination for Windows children and taskkill tree escalation for forced cleanup across Eval harness, external subjects, and preflight commands. Fixesapache#3892. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
taskkill.exetree escalation for forced cleanup.Fixes#3892.
Verification
npm run lintpassed.npm run format:checkpassed.npm --workspace @maka/eval run typecheckpassed.npm --workspace @maka/eval run buildpassed.npx knip --workspace apps/desktoppassed.npx knip --workspace packages/uipassed.node --test packages/eval/dist/__tests__/process-termination.test.js packages/eval/dist/__tests__/install-preflight.test.jspassed: 10 passed, 3 skipped because this Windows environment does not grant symlink/permission prerequisites.npm run typecheckis blocked by existing@maka/uierrors forsettledText,autoScroll, andtrailingAction; Eval and its dependencies typecheck successfully.npm run buildreaches the same existing@maka/uitype errors after building Eval and its dependencies.AI use
Tool(s) and scope: Codex implemented the process-termination helper, call-site updates, regression tests, and verification. The human contributor of record reviews the implementation for correctness and licensing.
Checklist
Does this PR entail a change in behavior?