Skip to content

refactor: preserve Daily Review on shared authorities - #4178

Draft
Astro-Han wants to merge 17 commits into
apache:mainfrom
Astro-Han:refactor/daily-review-converge-scheduled-task
Draft

refactor: preserve Daily Review on shared authorities#4178
Astro-Han wants to merge 17 commits into
apache:mainfrom
Astro-Han:refactor/daily-review-converge-scheduled-task

Conversation

@Astro-Han

@Astro-HanAstro-Han commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Daily Review stays a first-class Automations experience while its runtime converges on shared authorities:

  • ScheduledTask owns scheduling, timezone, retry, and run now.
  • ordinary Runtime Host Session / AgentRun / RuntimeEvent owns execution, recovery, and transcript.
  • ordinary Session + Markdown Artifact owns reports; the shared usage ledger is unchanged.

The UI keeps setup, run now, Today / 7 / 30 day navigation, task activity, report history, and backing-schedule management, with a simpler visual hierarchy and no duplicate report rows. The dedicated scheduler, resident state, model path, archive dashboard/store, protocol, and IPC are removed. Net diff: 1,956 lines deleted.

UI comparison

BeforeAfter
Daily Review before visual simplificationDaily Review after visual simplification

Migration and compatibility

Released two- and three-table layouts migrate idempotently. Existing configuration becomes one system-owned Daily Review preset task without changing enablement, timezone, or trigger semantics. Reports become deterministic Sessions, transcript messages, and Artifacts; retirement happens only after replacement writes and snapshot CAS succeed, so failure remains retryable without permanent dual read/write.

Legacy ScheduledTask Agent rows are rebound through canonical connection readiness or paused for repair. Runtime Host compatibility epoch advances to 69. Rolling back after retirement requires the pre-migration backup; migrated Sessions and Artifacts remain ordinary durable data.

Verification

  • 74 focused Core, Storage, Runtime Host, UI, and Desktop tests
  • 2 focused Desktop Playwright paths
  • affected builds and typechecks
  • Biome, Astryx inventory, and git diff --check

Full-repository tests were not run.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex implemented the migration, authority convergence, UX preservation, tests, and review fixes. Affected commits carry Generated-by: Codex trailers.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actionsgithub-actionsBot added the effort/XL Over 1000 readable lines label Aug 29, 2026
@Astro-HanAstro-Han changed the title refactor: converge Daily Review on scheduled tasksrefactor: preserve Daily Review on shared authoritiesAug 29, 2026
@Astro-Han
Astro-Hanforce-pushed the refactor/daily-review-converge-scheduled-task branch 3 times, most recently from 9f2da76 to e2b99b6CompareAugust 29, 2026 17:39
Migrate legacy configuration and reports into the ScheduledTask, ordinary Session, and Artifact authorities, then remove the dedicated runtime and UI chain.
Generated-by: Codex
Keep Daily Review as a first-class Automations experience while projecting its schedule, execution, history, and reports from ScheduledTask, ordinary Session, Artifact, and the shared usage ledger.
Generated-by: Codex
Carry selected review ranges through ordinary ScheduledTask fire claims, keep paused schedules paused after manual runs, reject new Agent tasks without immutable Connection identity, and preserve the legacy one-time catch-up trigger during migration.
Generated-by: Codex
@Astro-Han
Astro-Hanforce-pushed the refactor/daily-review-converge-scheduled-task branch from e2b99b6 to 51f2ab9CompareAugust 29, 2026 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XLOver 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Astro-Han