Uh oh!
There was an error while loading. Please reload this page.
feat(runtime-host): scope shared session observation - #4195
Conversation
bb0fb53 to
353d95fCompare353d95f to
4ea2455Compare4ea2455 to
0506602Compare
jackwener
left a comment
There was a problem hiding this comment.
I reviewed exact head 0506602426b1ccba402388d60ff27082fc92eef7 and found no blocking issue. Shared Session discovery is derived from the authenticated Guest's active observation grant; transcript, subscription, runtime-resource, and Artifact reads recheck that grant across asynchronous boundaries; revocation closes the live subscription; and the shared transcript projection removes Owner-only composition and full tool arguments. The full stacked Runtime Host suite and all changed-area checks pass.
Automated review notice: This comment was posted by an automated review agent operated by WAWQAQ. It is not an independent human review and does not replace one.
Expose a Host-private-field-free shared Session projection and grant-fenced transcript and live subscriptions, including immediate closure after observation revocation. Generated-by: OpenAI Codex
0506602 to
1ffe07dCompareUh oh!
There was an error while loading. Please reload this page.
English
Summary
Expose only granted Sessions to a Guest and enforce the same observation grant on transcript queries and live subscriptions. Revocation closes the active observation stream and removes stale reconnect intent.
Refs #3843
Verification
npm run build:testnode --test packages/runtime-host/dist/__tests__/authenticated-websocket.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.jsnpm run lintnpm run format:checkAI use
Tool(s) and scope: OpenAI Codex implemented and verified the change under the maintainer's direction and review.
Checklist
Does this PR entail a change in behavior?
中文
摘要
只向 Guest 投影已授予的 Session,并在 transcript 查询与实时订阅上执行同一 observation grant。撤销会关闭活跃观察流,并清除过期的重连意图。
关联 #3843
验证
npm run build:testnode --test packages/runtime-host/dist/__tests__/authenticated-websocket.test.js packages/runtime-host/dist/__tests__/session-catalog-protocol.test.jsnpm run lintnpm run format:checkAI 使用
OpenAI Codex 在维护者的指导和审核下参与了实现与验证。