Uh oh!
There was an error while loading. Please reload this page.
feat(runtime-host): admit approved guest Turn requests - #4197
Conversation
0ccbfbf to
dc68ac3Compare2cc6cb1 to
fb1fc06Compare2944be8 to
bf8bb7cCompare
jackwener
left a comment
There was a problem hiding this comment.
I reviewed exact head bf8bb7c97aa6a74c0112ce41d2e956a39f419235 and found no blocking issue. Guest requests keep one immutable Session/Turn/content identity, Owner approval is durably recorded as the exact Turn admission authorization, approved requests enter the canonical turn.start path, and restart or busy-Session recovery does not duplicate or lose a pending approval. Authority and admission regression tests pass, including restart, unknown-outcome, revocation, drain, and idle-wait cases; the full Runtime Host suite also passes.
Automated review notice: This comment was posted by an automated review agent operated by WAWQAQ. It is not an independent human review and does not replace one.
Persist immutable Guest Turn requests and Owner decisions, then recover approved exact intents through the canonical Turn admission path. Generated-by: OpenAI Codex
bf8bb7c to
dd6e899Compare
English
Summary
Add durable exact Turn access requests. A Guest requests one immutable
turn.startintent; the Owner decides it with revision fencing, and only an approved intent enters the canonical Turn admission path. Recovery schedules approved requests without delaying Host readiness, while idle-wait failures drain and leave the request recoverable. Turn-request visibility is derived from the authenticated connection identity, so a Guest can never be reclassified as an Owner by credential-state changes.Refs #3843
Verification
npm run build:testnode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.jsnode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.js packages/runtime-host/dist/__tests__/authenticated-websocket.test.jsnpm run lintnpm run format:checknpm run check:asf-headersgit diff --checkAI use
Tool(s) and scope: OpenAI Codex implemented and verified the change under the maintainer's direction and review.
Checklist
Does this PR entail a change in behavior?
中文
摘要
加入持久化的精确 Turn access request。Guest 请求一个不可变的
turn.startintent;Owner 通过 revision fence 决策,只有获批 intent 才进入 canonical Turn 准入路径。恢复过程不会因已批准请求而延迟 Host ready;等待 Session idle 失败时会进入 drain,并保留请求以供恢复。Turn request 的可见范围直接取自已认证连接身份,credential 状态变化不会把 Guest 误判为 Owner。关联 #3843
验证
npm run build:testnode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.jsnode --test packages/runtime-host/dist/__tests__/session-collaboration-authority.test.js packages/runtime-host/dist/__tests__/authenticated-websocket.test.jsnpm run lintnpm run format:checknpm run check:asf-headersgit diff --checkAI 使用
OpenAI Codex 在维护者的指导和审核下参与了实现与验证。