Uh oh!
There was an error while loading. Please reload this page.
Fix/startup white screen - #429
Merged
Merged
Conversation
sunheyi6force-pushed
the
fix/startup-white-screen
branch
2 times, most recently
from
July 2, 2026 13:43
4b22319 to
c94c2f9Compare… on startup - Add inline CSS + HTML skeleton in index.html that renders before React mounts and external CSS/JS loads - Skeleton matches .maka-onboarding-loading design with hardcoded theme-aware colors (light/dark via prefers-color-scheme) - No external dependencies — visible immediately after HTML parse - Eliminates blank white/gray screen during 355KB CSS + 5.8MB JS window
…pache#429) - startup-loading-shell contract: the second test asserted a Suspense/StartupFallback/maka-preload wiring in app.tsx that was never implemented (app.tsx imports AppShell eagerly). Repoint it at the actual fix — the inline preload skeleton in index.html — so it guards real behavior instead of a red, aspirational contract. - onboarding.css: the new .maka-onboarding-loading skeleton used bare border-radius: 12px/999px, violating the radius-token governance contract (apache#406/apache#418). Use var(--radius-modal)/var(--radius-pill). - package.json: restore root `dev` to the governed `dev:hmr` fast-HMR path (real-window-smoke contract); the new scripts/dev.mjs launcher stays available via `@maka/desktop run dev`. - .gitignore: drop the machine-specific `.suncode/` IDE dir leak. Full suite green: core/storage/runtime/headless/ui + 1671 desktop tests.
jackwenerforce-pushed
the
fix/startup-white-screen
branch
from
July 2, 2026 16:29
c94c2f9 to
3e99a23Comparejackwener
commented
Jul 2, 2026
Member
Merged — thanks! 🎉 The inline preload skeleton in I made a few review fixes before merging so the branch was green against
One note for next time: this PR bundled several unrelated changes (dev-launcher rework, |
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.