Skip to content

test(desktop): deselect-proof the code-scroll selection drag#4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Sep 3, 2026
+13 −5
Merged

test(desktop): deselect-proof the code-scroll selection drag #4632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions apps/desktop/e2e/code-scroll.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -100,12 +100,20 @@ test('a one-line Markdown code block exposes native and selection horizontal scr
(element as HTMLElement).scrollLeft = 0;
window.getSelection()?.removeAllRanges();
});
const code = viewport.locator('code');
const codeBox = await code.boundingBox();
if (!codeBox) throw new Error('code line has no visible bounds');
const textY = codeBox.y + Math.min(codeBox.height / 2, 18);
await page.mouse.move(codeBox.x + 24, textY);
const line = viewport.locator('code > [data-line]').first();
// Font loading reflows the glyphs; measure only after it settles or the
// anchor can land outside the text and no selection ever forms.
await page.evaluate(() => document.fonts.ready.then(() => undefined));
const lineBox = await line.boundingBox();
if (!lineBox) throw new Error('code line has no visible bounds');
const textY = lineBox.y + Math.min(lineBox.height / 2, 18);
await page.mouse.move(lineBox.x + 24, textY);
await page.mouse.down();
// Prove the selection anchored before the long auto-scroll drag.
await page.mouse.move(lineBox.x + 90, textY, { steps: 6 });
await expect.poll(
() => viewport.evaluate(() => window.getSelection()?.toString().length ?? 0),
).toBeGreaterThan(0);
await page.mouse.move(metrics.rect.x + metrics.rect.width + 50, textY, { steps: 20 });
await expect.poll(
() => viewport.evaluate((element) => (element as HTMLElement).scrollLeft),
Expand Down