Uh oh!
There was an error while loading. Please reload this page.
feat(design): toast exit window + lucide stroke governance (D5/D6) - #483
Merged
Conversation
Two queue items from the round-2 study: Toast exit (completes #471's lifecycle): dismissal is now two-phase — the entry is marked exiting, a 180ms shrink/fade plays (exit = enter 240ms x 75%, roadmap motion rule), then the entry unmounts. Toasts no longer vanish mid-glance; exiting toasts drop pointer-events. Exit keyframes whitelisted in the #406 functional-motion contract. Lucide stroke governance (decision D5): call sites had EIGHT different strokeWidth values (1.5/1.6/1.65/1.7/1.75/1.8/1.85/2) across 143 usages plus the default 2 wherever unspecified. One rule (svg.lucide { stroke-width: 1.75 }) overrides every SVG presentation attribute, unifying all glyphs at the distribution's modal weight with zero call-site churn. icon-system-contract gains the positive assertion; its size-hammer ban regex gets (?<!-) so the governed stroke-width rule doesn't false-positive on "width". Markdown parse caching (queue item) evaluated and DOWNGRADED: memoized MessageBody already prevents re-parsing committed turns; the streaming turn's re-parse is essential work. Noted here so it isn't re-proposed. Desktop suite 1697/1697 (+1 contract).
Astro-Han added a commit
that referenced
this pull request
Jul 3, 2026
5 CSS files (daily-review, health-center, permission-center, settings/connection, tool-stream) took main's format (@layer removal, indentation) and re-applied foreground alias replacement (40/50→muted-foreground, 60/70/80→foreground-secondary).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
队列两项：
Toast 退场窗口（补完 #471 的生命周期）
dismiss 改两阶段：标记 exiting → 180ms 收缩淡出（退场 = 进场 240ms × 75%，roadmap 动效规则）→ 卸载。toast 不再在注视中瞬间消失；退场中丢弃 pointer-events。
Lucide stroke 治理（D5 兑现）
调用点累积了 8 种 strokeWidth（1.5→2）共 143 处 + 未指定处默认 2 —— 典型「说不清为什么不精致」。一行
svg.lucide { stroke-width: 1.75 }覆盖全部 SVG presentation attribute，零调用点改动全量统一到分布主峰值。icon 契约加正向断言；顺修旧 size-hammer 断言的\bwidth误匹配 stroke-width。Markdown 缓存项评估后降级
MessageBody memo 已阻止已提交 turn 的重 parse；流式 turn 的重 parse 是本质工作。记录在案防止重提。
1697/1697（+1 契约）。