Uh oh!
There was an error while loading. Please reload this page.
fix(ui-react): harden chat async and lazy fallbacks - #489
Merged
Conversation
Astro-Han
commented
Jul 3, 2026
ContributorAuthor
Review response pushed. Refs #477. Changes:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Part of #477.
Async scope in this PR is intentionally limited to:
Voice Settings is not changed in production here. Its microphone permission probe already catches
navigator.permissions.query()rejection and returnsunknown; this PR adds a contract for that existing boundary.User-visible impact is limited to compact loading placeholders for surfaces that are already supposed to be visible. ArtifactPane now preserves the existing default-hidden product contract while its lazy chunk loads.
Verification
ArtifactPaneFallbackrendered a fake.maka-artifact-panenpm run -w @maka/desktop test(1727 passed)npm run -w @maka/desktop build:renderer(passes; existing Vite large chunk warning remains)npm --workspace @maka/ui run build && npm run -w @maka/desktop build:main && node --test dist/main/__tests__/renderer-async-boundaries-contract.test.js dist/main/__tests__/session-sticky-model-contract.test.js dist/main/__tests__/session-row-actions-fail-soft-contract.test.jsnpm run -w @maka/desktop build:main && node --test dist/main/__tests__/renderer-lazy-fallback-contract.test.jsnpm run -w @maka/desktop build:main && node --test dist/main/__tests__/voice-capture-smoke-contract.test.jsnpm run -w @maka/ui teststill fails in existingchat-primitivesfooter-action / lineage-badge pixel merge assertions; those files are untouched by this PRCommit Split
fix(ui-react): catch model switcher rejectionfix(ui-react): catch session row action rejectionfix(ui-react): add shell lazy fallbacksfix(ui-react): add module lazy fallbacksfix(ui-react): keep artifact pane lazy fallback hiddenrefactor(ui-react): inline async pending cleanuptest(ui-react): pin voice permission probe rejection