Uh oh!
There was an error while loading. Please reload this page.
fix(ui): chat surface unify + startup flash + daily-review IA + dead-code cleanup (round 4) - #492
Merged
Merged
Conversation
- .maka-main painted solid var(--background) over only the chat scroll area, so on darwin glass (--agents-content-area-bg #fafafa) the composer region below read as a THIRD color band (shell / chat / composer). Now transparent: one panel, one surface, both themes. - remove the dead theme-glass darwin .maka-panel-detail override — it always lost to the .agents-content-area rule on specificity (0,3,0 vs 0,2,1) and its half-applied intent is what created the band. - snapshot session seeding moves useEffect → useLayoutEffect: the snapshot render un-gates the loading state while sessions is still [], and a passive effect seeds after paint — users with history saw a one-frame empty-state hero flash on every startup (闪屏). permission-response-ipc-boundary contract updated to accept the layout effect on the boot path.
- marketplace card 安装 was a permanently-disabled button — a dead control that promises interactivity (the codebase already replaced the filter pills for the same reason). Now a static 即将上线 pill. - drop 6 never-imported lucide icon re-exports from @maka/ui/icons. - un-export 4 internal-only helpers (plan-reminder sort ranks, createAbsoluteTimeFormat) — file-local implementation details. smooth-stream helpers stay exported: they're unit-tested.
…pass 1) Owner feedback: 页面太乱、不直观. Root of the mess was time context split across the page — date stepper at top, 今日/本周/本月 tabs floating mid-page above the stats they control, with a two-paragraph explainer card pushing everything below the fold. - header is now the one time bar: stepper + day label left, range tabs right (tabs relocated from the mid-page nav, which is gone). - explainer card unboxed to a single quiet hint line. - export actions (复制/粘到输入框/保存) keep their conditional but now sit directly above the stats they export, right-aligned. - radius contract entry for the retired info card removed.
- 保持系统唤醒 was a permanently-disabled Switch (checked=false, aria-label literally said 暂未启用) — a dead toggle promising interactivity. Now a static 即将支持 pill in the info-alert tint, same precedent as the skills marketplace 即将上线 tag. - completed one-shot reminders showed a disabled OFF switch that read as 'paused', not 'done' — a terminal state can't be re-enabled, so the card chrome now shows an 已完成 badge instead of the toggle.
The four report blocks (对话摘要/遗漏提醒/使用洞察/代码建议) sat at a uniform 8px cadence and read as one slab. 8px within a section, 16px + hairline divider between sections — divider over nested cards per the anti-nested-box rule.
…n pipeline Reports are LLM-generated markdown; flat pre-wrap <p> text turned bullet lists and inline code into mush. Reuse the chat Markdown component (lazy pipeline, secret redaction, link gating included) and restore list markers locally (preflight strips them).
…-aligned prose SettingRow gains an opt-in mono value mode (data-mono) — long machine values like the workspace path wrapped into a ragged right-aligned 3-line block in proportional type. Mono + left-aligned + caption size reads as the file path it is. First consumer: 数据 page 工作区路径.
The path + backup/draft/count status words floated unboxed between two cards and read as orphaned fragments. A hairline top border + breathing room marks the strip as the editor's status footnote (divider over a nested card, per the anti-nested-box rule).
shortId sliced the raw turnId, but real ids start with turn- and the
labels interpolate as turn ${shortId} — badges rendered「已重新生成 →
turn turn-r」with one useful character of id. Strip the prefix first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #488 在第一波修复后已被合入，本 PR 承接其后未进 main 的三个 commit（已在最新 main 上 cherry-pick 并适配 #487 CSS 拆分 / #479 文字层级收敛 / #485 cascade 整理）。
修复清单
.maka-main只给聊天滚动区刷纯白，darwin 玻璃下与面板容器色 #fafafa 形成 composer 第三色带。改 transparent —— 右面板单一表面；顺带删除 theme-glass 里打不赢 cascade 的死规则（0,2,1 vs 0,3,0）。验证（在最新 main 基础上）
@maka/desktop1821 tests 全绿 / check-dead-css ✓ / check-copy ✓@maka/ui2 个存量失败（chat-primitives tailwind-merge 断言）为 main 已有问题，另行跟进后续追加（同分支，loop 迭代）
全部：desktop 1821 tests ✓ / typecheck ✓ / dead-css ✓ / 截图验收。