Uh oh!
There was an error while loading. Please reload this page.
refactor(ui-react): split tool activity previews - #497
Merged
Conversation
Astro-Han
commented
Jul 4, 2026
ContributorAuthor
Review response pushed in
Verification:
|
Astro-Han
commented
Jul 4, 2026
ContributorAuthor
Review response pushed in
Verification:
|
Astro-Han
commented
Jul 4, 2026
ContributorAuthor
Fixed the latest P3 review in Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-result-preview.tsx, while keeping the largeragent-preview.tsxsplit out and preserving the publicToolActivity,OverlayHost, andformatBytesexportsdata-kind, visible copy, redaction, truncation, and fallback behavior throughOverlayHost--foreground-50color with the semantic--muted-foregroundalias so the full foreground-tier contract stays greenScope
Part of #477.
This PR is a structural React/UI ownership split, not a visual redesign. The final shape keeps
tool-activity.tsxas the shell,tool-result-preview.tsxas the small result-card owner,agent-preview.tsxas the complex agent result owner, andpreview-utils.tsfor shared formatting/capping helpers. Existing result-specific contracts still cover web search, Office documents, Rive workflow, terminal truncation, explore agent, and subagent rendering.The CSS change is intentionally limited to an equivalent semantic-token replacement for
.maka-lazy-fallback(--muted-foregroundis the 50% foreground alias). It was included becausenpm run -w @maka/desktop testfailed onmainwith the raw token, blocking full-suite verification.Verification
npm run -w @maka/desktop test(1830 passed)npm run -w @maka/desktop build:renderer(passes; existing Vite large chunk warning remains)npm run -w @maka/desktop build:main && cd apps/desktop && node --test dist/main/__tests__/explore-agent-tool.test.js dist/main/__tests__/tool-activity-result-preview-contract.test.js(20 passed)npm run -w @maka/ui build && npm run -w @maka/desktop build:main && cd apps/desktop && node --test dist/main/__tests__/tool-activity-result-preview-contract.test.js dist/main/__tests__/explore-agent-tool.test.js dist/main/__tests__/visible-copy-hygiene-contract.test.jsnpm run -w @maka/ui build && npm run -w @maka/desktop build:main && cd apps/desktop && node --test dist/main/__tests__/tool-activity-result-preview-contract.test.js dist/main/__tests__/rive-workflow-tool.test.jsnpm run -w @maka/desktop build:main && cd apps/desktop && node --test dist/main/__tests__/foreground-tier-contract.test.jsCommit Split
Original split:
refactor(ui-react): extract tool preview utilitiesrefactor(ui-react): extract web and diff previewsrefactor(ui-react): extract office and terminal previewsrefactor(ui-react): extract rive workflow previewrefactor(ui-react): extract agent result previewstest(ui-react): lock tool preview ownershiptest(ui-react): route explore preview contract through overlayfix(ui-css): use semantic lazy fallback colorReview response:
refactor(ui-react): consolidate tool result previewsfix(ui-react): redact rive workflow preview errorsfix(ui-react): redact rive workflow preview bodyfix(ui-react): redact explore copy payloadstest(desktop): loosen explore copy contract