Uh oh!
There was an error while loading. Please reload this page.
refactor(ui-react): split session list modules - #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionListPanelinto a small sidebar shell,session-sidebar-nav.tsxfor the module nav/settings footer, andsession-history-list.tsxfor session groups, rows, row actions, status icons, and time bucketsSessionListPanel; Skills, Automations, and Daily Review callbacks remain owned byChatView, where those module panels are actually renderedsessionsmodule-nav branch; the new-task button still owns new-chat creation, and the three module nav buttons still select Daily Review, Skills, and AutomationsSessionListPanelin contracts for OverlayScrollArea, time-bucket copy, and blocked-reason copy; row-action source contracts now resolve only theSessionHistoryListowner rendered bySessionListPanel!importantfrom the palette input focus reset so the renderer important audit stays greenScope
Part of #477.
This PR is structural only, not a visual redesign. The original #477 wording mentioned splitting
session-list-panel.tsxinto sessions / skills / plan reminders / daily review surfaces, but currentmainalready renders those module panels throughChatView. The minimal correct PR6 is therefore to split the remaining sidebar owner into shell, nav/footer, and session-history modules, while removing now-dead module callback props from the sidebar contract.Verification
npm run -w @maka/desktop build:mainnode --test apps/desktop/dist/main/__tests__/session-list-public-contract.test.js apps/desktop/dist/main/__tests__/session-row-actions-fail-soft-contract.test.js apps/desktop/dist/main/__tests__/renderer-async-boundaries-contract.test.js apps/desktop/dist/main/__tests__/overlay-scrollbars-contract.test.js apps/desktop/dist/main/__tests__/search-modal-lifecycle-contract.test.js apps/desktop/dist/main/__tests__/daily-review-export-file-contract.test.js(34 passed)npm run -w @maka/desktop test(1837 passed)npm run -w @maka/desktop build:renderer(passes; existing Vite large chunk warning remains)Commit Split
fix(ui-css): remove palette input important resetrefactor(ui-react): split session list modulesrefactor(ui-react): narrow session sidebar nav targetstest(desktop): loosen session list contractstest(desktop): narrow session list contract sources