Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(composer): workspace picker, git branch switching, and composer defaults persistence by sunheyi6 · Pull Request #511 · apache/maka · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src/global.d.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -436,6 +436,27 @@ declare global {
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'cancelled' | 'missing-selection' }
>;
selectProjectRoot(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
resolveProjectGitInfo(projectPath: string): Promise<
| { ok: true; projectPath: string; projectGit: { isGitRepo: boolean; branch?: string } }
| { ok: false; reason: 'invalid-path' | 'not-found' }
>;
listGitBranches(): Promise<{
ok: boolean;
branches?: string[];
current?: string;
reason?: string;
message?: string;
}>;
checkoutGitBranch(branch: string): Promise<{
ok: boolean;
branch?: string;
reason?: string;
message?: string;
}>;
openArtifactPath(
artifactId: string,
): Promise<
Expand Down
67 changes: 67 additions & 0 deletions apps/desktop/src/main/__tests__/bot-incoming-project-cwd.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { strict as assert } from 'node:assert';
import { describe, it } from 'node:test';
import type { BotIncomingMessage, BotRegistry, SessionManager } from '@maka/runtime';
import { createBotIncomingMainService } from '../bot-incoming-main.js';

describe('bot incoming new-session cwd', () => {
it('creates the bot session with the current project root, not process.cwd()', async () => {
let capturedCwd: unknown = undefined;
let resolveCreated: () => void = () => {};
const created = new Promise<void>((resolve) => {
resolveCreated = resolve;
});
const service = createBotIncomingMainService({
// createSession captures the cwd it was given, signals the test, then
// throws to short-circuit before the streaming / typing path runs.
runtime: {
async createSession(input: { cwd?: unknown }) {
capturedCwd = input.cwd;
resolveCreated();
throw new Error('__short_circuit_after_create__');
},
} as unknown as SessionManager,
botRegistry: {
async sendMessage() {},
async sendTypingIndicator() {
return false;
},
isImplemented() {
return true;
},
} as unknown as BotRegistry,
getCurrentProjectRoot: async () => '/custom/project/root',
getDefaultConnectionSlug: async () => 'slug',
getReadyConnection: async () => ({ connection: { slug: 'slug' }, model: 'm' }),
readSessionHeader: async () => ({ permissionMode: 'ask' }),
ensureSessionCanSend: async () => {},
emitSessionsChanged() {},
sendToRenderer() {},
isStatusChangingSessionEvent() {
return false;
},
isTurnStatusChangingSessionEvent() {
return false;
},
});

await service.handleBotIncomingMessage({
platform: 'telegram',
userId: 'u',
userName: 'U',
chatId: 'c1',
isGroup: false,
text: 'hello',
sourceMessageId: '',
receivedAt: Date.now(),
} as unknown as BotIncomingMessage);

// handleBotIncomingMessage returns before the queued create runs; wait
// for createSession to actually be invoked (or time out).
await Promise.race([
created,
new Promise<void>((_, reject) => setTimeout(() => reject(new Error('createSession was not called')), 1000)),
]);

assert.equal(capturedCwd, '/custom/project/root');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,8 +99,8 @@ describe('home composer new-chat model picker', () => {
);
assert.match(
renderer,
/onPickNewChatModel=\{\(input\) => setPendingNewChatModel\(input\)\}/,
'main.tsx must wire the composer pick to setPendingNewChatModel',
/onPickNewChatModel=\{\(input\) => \{[\s\S]*setPendingNewChatModel\(input\);[\s\S]*saveComposerDefaults\(\{ model: input \}\);[\s\S]*\}\}/,
'main.tsx must wire the composer pick to state and persisted composer defaults',
);
// A pick only stays in effect while it is still an offered choice; once the
// connection/model is removed the picker must fall back to the default so it
Expand DownExpand Up@@ -150,7 +150,22 @@ describe('home composer new-chat model picker', () => {
assert.match(
renderer,
/const \[pendingNewChatPermissionMode, setPendingNewChatPermissionMode\] = useState<PermissionMode \| null>\(null\)/,
'AppShell must keep the picked empty-state permission mode in renderer-only state',
'AppShell must keep the no-session permission pick renderer-only and start it from null',
);
assert.doesNotMatch(
renderer,
/saveComposerDefaults\(\{\s*permissionMode:/,
'permission mode must not be persisted into composer defaults',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode: \(mode: PendingNewChatPermissionMode\) => void;/,
'createAppShellChatActions deps must include setPendingNewChatPermissionMode so send() can reset the one-shot pick',
);
assert.match(
renderer,
/setPendingNewChatPermissionMode,[\s\S]*validPendingNewChatModel,/,
'createAppShellChatActions must destructure setPendingNewChatPermissionMode before send() calls it',
);
assert.match(
setPermissionModeBlock,
Expand Down
231 changes: 231 additions & 0 deletions apps/desktop/src/main/__tests__/git-branch.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,231 @@
import { strict as assert } from 'node:assert';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import { describe, it } from 'node:test';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import type { ExecFileException } from 'node:child_process';
import { listLocalBranches, checkoutBranch } from '../git-branch.js';

type ExecFileCallback = (
file: string,
args: readonly string[],
options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => void;

function fakeExecFile(onExecute: (args: readonly string[]) => {
error: ExecFileException | null;
stdout: string;
stderr: string;
}): ExecFileCallback {
return (
_file: string,
args: readonly string[],
_options: { cwd: string; timeout: number; windowsHide: boolean },
cb: (error: ExecFileException | null, stdout: string, stderr: string) => void,
) => {
const result = onExecute(args);
cb(result.error, result.stdout, result.stderr);
};
}

function errnoException(code: string, message?: string): ExecFileException {
const err = new Error(message ?? code) as NodeJS.ErrnoException & ExecFileException;
err.code = code;
err.name = 'Error';
return err as unknown as ExecFileException;
}

async function withGitRepo(run: (gitRoot: string) => Promise<void>): Promise<void> {
const root = await mkdtemp(join(tmpdir(), 'maka-git-test-'));
await mkdir(join(root, '.git'), { recursive: true });
await writeFile(join(root, '.git', 'HEAD'), 'ref: refs/heads/main\n', 'utf8');
try {
await run(root);
} finally {
await rm(root, { recursive: true, force: true });
}
}

describe('listLocalBranches', () => {
it('parses `git branch --list` output with current branch marked by *', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile((args) => {
assert.deepEqual(args, ['branch', '--list']);
return { error: null, stdout: '* main\n develop\n feature/sidebar\n', stderr: '' };
});
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop', 'feature/sidebar']);
assert.equal(result.current, 'main');
});
});

it('detects detached HEAD (no * branch)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* (HEAD detached at abc1234)\n main\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, undefined);
});
});

it('handles a single-branch repo', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main']);
assert.equal(result.current, 'main');
});
});

it('deduplicates branch names', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: null,
stdout: '* main\n develop\n develop\n',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, true);
assert.deepEqual(result.branches, ['main', 'develop']);
assert.equal(result.current, 'main');
});
});

it('returns not-a-repo when project lacks .git metadata', async () => {
const result = await listLocalBranches('/tmp/non-existent');
assert.equal(result.ok, false);
assert.equal(result.reason, 'not-a-repo');
});

it('returns missing-git when git binary is not found (ENOENT)', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: errnoException('ENOENT', 'spawn git ENOENT'),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'missing-git');
});
});

it('returns timeout when git takes too long', async () => {
await withGitRepo(async (root) => {
const execFileImpl = fakeExecFile(() => ({
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
}));
const result = await listLocalBranches(root, { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
});
});
});

describe('checkoutBranch', () => {
it('switches to a valid branch and returns the new branch name', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.ok(result.ok);
assert.deepEqual(gitCalls, [
['status', '--porcelain'],
['checkout', 'develop'],
]);
});
});

it('rejects invalid branch names', async () => {
const result = await checkoutBranch('/fake/repo', 'bad; branch');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.match(result.message ?? '', /无效的分支名/);
});

it('rejects empty branch name', async () => {
const result = await checkoutBranch('/fake/repo', '');
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
});

it('refuses checkout when worktree is dirty', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return { error: null, stdout: 'M index.ts\n', stderr: '' };
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'dirty');
assert.equal(result.message, '工作区有未提交的更改,请先提交或暂存。');
// The only git command that was run was `git status --porcelain`;
// `git checkout` must NOT be called on a dirty worktree.
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command fails', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: errnoException('EACCES', 'status failed'),
stdout: '',
stderr: 'fatal: cannot inspect worktree',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'failed');
assert.equal(result.message, 'fatal: cannot inspect worktree');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});

it('fails closed when dirty-check status command times out', async () => {
await withGitRepo(async (root) => {
const gitCalls: string[][] = [];
const execFileImpl = fakeExecFile((args) => {
gitCalls.push([...args]);
if (args[0] === 'status' && args[1] === '--porcelain') {
return {
error: Object.assign(errnoException('ETIMEDOUT', 'timeout'), { killed: true }),
stdout: '',
stderr: '',
};
}
return { error: null, stdout: '', stderr: '' };
});
const result = await checkoutBranch(root, 'develop', { execFileImpl });
assert.equal(result.ok, false);
assert.equal(result.reason, 'timeout');
assert.deepEqual(gitCalls, [['status', '--porcelain']]);
});
});
});
Loading