') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(desktop): kill startup flash — prefetch onboarding snapshot before React mounts by jackwener · Pull Request #525 · apache/maka · GitHub
Skip to content

fix(desktop): kill startup flash — prefetch onboarding snapshot before React mounts - #525

Merged
Astro-Han merged 1 commit into
mainfrom
fix/startup-flash-prefetch-snapshot
Jul 5, 2026
Merged

fix(desktop): kill startup flash — prefetch onboarding snapshot before React mounts#525
Astro-Han merged 1 commit into
mainfrom
fix/startup-flash-prefetch-snapshot

Conversation

@jackwener

@jackwenerjackwener commented Jul 4, 2026

Copy link
Copy Markdown
Member

问题

启动时会闪过'像配置页一样'的灰色卡片（用户反馈的启动闪屏）。

根因（CDP screencast 实测）

真实启动序列闪过 三张不同的灰卡：

  1. 0–2.6s：index.html 的 preload 骨架卡（全窗口居中）
  2. ~3.0s：React 挂载后换成 .maka-onboarding-loading 卡（位于内容面板内，几何位置不同 → 肉眼可见跳动）
  3. ~3.3s：卡片再次移位
  4. ~3.7s：聊天页才出现

修复

main.tsx 在 createRoot().render() 之前预取 onboarding:getSnapshot（失败重试一次 + 2.5s fail-open 超时）。preload 骨架保持到 React 首次 commit，而首次 commit 已带 sessions + connections，直接绘制真实聊天界面。

验证

  • CDP screencast 复测：preload 骨架 → 聊天页，中间无任何卡片
  • npm --workspace @maka/desktop test：1892/1892 通过
  • typecheck 通过

@jackwener
fix(desktop): kill startup flash — prefetch onboarding snapshot befor…
00a1756
…e React mounts
The startup sequence flashed three different gray cards (preload skeleton
→ React loading card that jumped position twice → chat), which read as
'a config page flashing by'. CDP screencast of a real launch confirmed
the intermediate .maka-onboarding-loading card at ~3.0s and ~3.3s.
main.tsx now prefetches onboarding:getSnapshot before createRoot renders
(one retry + 2.5s fail-open timeout). The preload skeleton stays visible
until the first React commit, which already has sessions + connections
seeded, so the app paints the real chat surface directly — verified by
re-running the CDP screencast probe: preload skeleton → chat, no
intermediate card.
Astro-Han
Astro-Han approved these changes Jul 5, 2026
View reviewed changes

@Astro-HanAstro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Astro-Han
Astro-Han merged commit 1490049 into mainJul 5, 2026
@Astro-Han
Astro-Han deleted the fix/startup-flash-prefetch-snapshot branch July 5, 2026 07:58
@Astro-HanAstro-Han mentioned this pull request Jul 7, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Astro-HanAstro-HanAstro-Han approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackwener@Astro-Han