fix(desktop): fresh sweep on new tip — restraint consistency, bot primary, honest fade by jackwener · Pull Request #722 · apache/maka

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener · 2026-07-11T15:56:16Z

Discovery sweep over today's externally-merged tip (LiteLLM #707, Goal #625, FormatJson #658, tool-row rework #712/#717/#721 — all reviewed clean; the Goal kill-switch pill correctly absorbed the earlier maintainer-review blockers: visible, one-click stoppable, Target icon through the funnel, mode-pill recipe).

Three finds, all fixed and CDP-verified:

每日回顾已生成 chip was success-green — expected outcomes are neutral per the fix(desktop): status-color restraint — expected states stop shouting green #651 restraint rule (健康正常 / 权限已授权 precedents); failures keep destructive.
机器人对话 had no primary anywhere — 测试并连接, the form's completion action, promoted to default.
first-run 28px bottom fade left the clipped provider row half-legible (still read as broken); 56px fully veils it.

Process note: a JSX syntax error passed the 2309-test suite untouched — the suite never compiles renderer pages; only vite/typecheck catches it. Full npm run typecheck added to this round's gate (and worth wiring into CI later).

Desktop 2309/2309 + typecheck + dead-css clean.

…mary, honest fade (round 16) Post-pull discovery sweep over the externally-merged tip (LiteLLM, Goal #625, FormatJson, tool-row rework — all reviewed clean, incl. the Goal kill-switch pill which correctly absorbed the earlier review blockers). Three finds, fixed: - 每日回顾已生成 chip still success-green — the EXPECTED outcome per the #651 restraint rule (健康正常 and 权限已授权 are already neutral); failures keep destructive. - 机器人对话 had NO primary at all — 测试并连接 (the form's completion action) promoted from secondary to default. - first-run provider list: the 28px bottom fade left a half-clipped row still half-legible — read as broken clipping; 56px fully veils it. Also re-learned: the desktop test suite does not compile renderer pages (a JSX syntax error sailed through 2309 green tests and only vite/ typecheck caught it) — full typecheck now part of this round's gate. Desktop 2309/2309 + typecheck + dead-css clean; CDP captures verified.

jackwener merged commit b03105f into mainJul 11, 2026
2 of 3 checks passed

jackwener deleted the fix/fresh-sweep-r16 branch July 11, 2026 15:56

Astro-Han mentioned this pull request Jul 11, 2026
refactor(ui): close out post-#520 renderer surface polish #546
Closed
7 tasks